{"thread":{"id":"26253","subject":"[PATCH] exec_cmd: remove unused extern","startedAt":"2011-01-10T22:00:49Z","lastAt":"2011-03-24T10:44:04Z","messageCount":3,"participants":["Erik Faye-Lund"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"159293","messageId":"1294696849-1428-1-git-send-email-kusmabite@gmail.com","threadId":"26253","inReplyTo":null,"subject":"[PATCH] exec_cmd: remove unused extern","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-10T22:00:49Z","receivedAt":"2011-01-10T22:00:49Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"This definition was added by commit 77cb17e9, but it's left unused since\ncommit 511707d. Remove the left-over definition.\n\nSigned-off-by: Erik Faye-Lund <kusmabite@gmail.com>\n---\n\nJust a left-over definition I found while looking through some code.\n\n exec_cmd.c |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/exec_cmd.c b/exec_cmd.c\nindex bf22570..38545e8 100644\n--- a/exec_cmd.c\n+++ b/exec_cmd.c\n@@ -3,7 +3,6 @@\n #include \"quote.h\"\n #define MAX_ARGS\t32\n \n-extern char **environ;\n static const char *argv_exec_path;\n static const char *argv0_path;\n \n-- \n1.7.4.rc1.3196.gfd693\n"},{"id":"164221","messageId":"AANLkTinhknijHo9Qo=rqik3ksjT27AVSLhcac-tGByx9@mail.gmail.com","threadId":"26253","inReplyTo":"1294696849-1428-1-git-send-email-kusmabite@gmail.com","subject":"Re: [PATCH] exec_cmd: remove unused extern","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-03-24T10:39:01Z","receivedAt":"2011-03-24T10:39:01Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> This definition was added by commit 77cb17e9, but it's left unused since\n> commit 511707d. Remove the left-over definition.\n>\n> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>\n> ---\n>\n> Just a left-over definition I found while looking through some code.\n>\n>  exec_cmd.c |    1 -\n>  1 files changed, 0 insertions(+), 1 deletions(-)\n>\n> diff --git a/exec_cmd.c b/exec_cmd.c\n> index bf22570..38545e8 100644\n> --- a/exec_cmd.c\n> +++ b/exec_cmd.c\n> @@ -3,7 +3,6 @@\n>  #include \"quote.h\"\n>  #define MAX_ARGS       32\n>\n> -extern char **environ;\n>  static const char *argv_exec_path;\n>  static const char *argv0_path;\n>\n\nBump? Or is this just too insignificant?\n"},{"id":"164222","messageId":"AANLkTimgYHGAebKeZyqnM99UBw=_ML0AVHY2oZgy+08o@mail.gmail.com","threadId":"26253","inReplyTo":"AANLkTinhknijHo9Qo=rqik3ksjT27AVSLhcac-tGByx9@mail.gmail.com","subject":"Re: [PATCH] exec_cmd: remove unused extern","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-03-24T10:44:04Z","receivedAt":"2011-03-24T10:44:04Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Thu, Mar 24, 2011 at 11:39 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> On Mon, Jan 10, 2011 at 11:00 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>> This definition was added by commit 77cb17e9, but it's left unused since\n>> commit 511707d. Remove the left-over definition.\n>>\n>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>\n>> ---\n>>\n>> Just a left-over definition I found while looking through some code.\n>>\n>>  exec_cmd.c |    1 -\n>>  1 files changed, 0 insertions(+), 1 deletions(-)\n>>\n>> diff --git a/exec_cmd.c b/exec_cmd.c\n>> index bf22570..38545e8 100644\n>> --- a/exec_cmd.c\n>> +++ b/exec_cmd.c\n>> @@ -3,7 +3,6 @@\n>>  #include \"quote.h\"\n>>  #define MAX_ARGS       32\n>>\n>> -extern char **environ;\n>>  static const char *argv_exec_path;\n>>  static const char *argv0_path;\n>>\n>\n> Bump? Or is this just too insignificant?\n>\n\nSorry for the noise. This has already been applied, I just experienced\na brain fart while checking.\n"}]}