threads / patch / 26008

patcht9143: do not fail when unhandled.log.gz is not created

Subject: [PATCH] t9143: do not fail when unhandled.log.gz is not created

## tl;dr

3 messages between Dec 9, 2010 and Dec 10, 2010. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Torsten Bögershausen· Dec 9, 2010, 19:53 UTC · lore

Do not depend on internal implementation details of svn, which right now uses perl to create a .gz file. So this test case will even work in the future, when svn changes its implementation.

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
  t/t9143-git-svn-gc.sh |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)

Show changes to t/t9143-git-svn-gc.sh +1 −2

diff --git a/t/t9143-git-svn-gc.sh b/t/t9143-git-svn-gc.sh
index 337ea59..4594e1a 100755
--- a/t/t9143-git-svn-gc.sh
+++ b/t/t9143-git-svn-gc.sh
@@ -37,13 +37,11 @@ test_expect_success 'git svn gc runs' 'git svn gc'
   test_expect_success 'git svn index removed' '! test -f 
.git/svn/refs/remotes/git-svn/index'
  -if perl -MCompress::Zlib -e 0 2>/dev/null
+if test -r .git/svn/refs/remotes/git-svn/unhandled.log.gz
  then
  	test_expect_success 'git svn gc produces a valid gzip file' '
  		 gunzip .git/svn/refs/remotes/git-svn/unhandled.log.gz
  		'
-else
-	say "# Perl Compress::Zlib unavailable, skipping gunzip test"
  fi
   test_expect_success 'git svn gc does not change unhandled.log files' '

-- 
1.6.6

Eric Wong· Dec 9, 2010, 21:31 UTC · re: Torsten Bögershausen · lore

Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created

Torsten Bögershausen <tboegi@web.de> wrote:

Show 6 quoted lines

> Do not depend on internal implementation details of svn,
> which right now uses perl to create a .gz file.
> So this test case will even work in the future,
> when svn changes its implementation.
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>

Thanks Torsten, I needed to fix whitespace mangling from your mailer to get it to apply cleanly.

Acked-by: Eric Wong <normalperson@yhbt.net>

It's pushed out to git://git.bogomips.org/git-svn along with an older patch from Steven:

Steven Walter (1):
      git-svn: allow the mergeinfo property to be set

Torsten Bögershausen (1):
      t9143: do not fail when unhandled.log.gz is not created

-- 
Eric Wong

Junio C Hamano· Dec 10, 2010, 00:11 UTC · re: Eric Wong · lore

Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created

Eric Wong <normalperson@yhbt.net> writes:

Show 8 quoted lines

> It's pushed out to git://git.bogomips.org/git-svn along with an
> older patch from Steven:
>
> Steven Walter (1):
>       git-svn: allow the mergeinfo property to be set
>
> Torsten Bögershausen (1):
>       t9143: do not fail when unhandled.log.gz is not created

Thanks; will pull.