{"thread":{"id":"26008","subject":"[PATCH] t9143: do not fail when unhandled.log.gz is not created","startedAt":"2010-12-09T19:53:19Z","lastAt":"2010-12-10T00:11:43Z","messageCount":3,"participants":["Torsten Bögershausen","Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"157714","messageId":"4D0133AF.40000@web.de","threadId":"26008","inReplyTo":null,"subject":"[PATCH] t9143: do not fail when unhandled.log.gz is not created","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2010-12-09T19:53:19Z","receivedAt":"2010-12-09T19:53:19Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Do not depend on internal implementation details of svn,\nwhich right now uses perl to create a .gz file.\nSo this test case will even work in the future,\nwhen svn changes its implementation.\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n  t/t9143-git-svn-gc.sh |    4 +---\n  1 files changed, 1 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t9143-git-svn-gc.sh b/t/t9143-git-svn-gc.sh\nindex 337ea59..4594e1a 100755\n--- a/t/t9143-git-svn-gc.sh\n+++ b/t/t9143-git-svn-gc.sh\n@@ -37,13 +37,11 @@ test_expect_success 'git svn gc runs' 'git svn gc'\n   test_expect_success 'git svn index removed' '! test -f \n.git/svn/refs/remotes/git-svn/index'\n  -if perl -MCompress::Zlib -e 0 2>/dev/null\n+if test -r .git/svn/refs/remotes/git-svn/unhandled.log.gz\n  then\n  \ttest_expect_success 'git svn gc produces a valid gzip file' '\n  \t\t gunzip .git/svn/refs/remotes/git-svn/unhandled.log.gz\n  \t\t'\n-else\n-\tsay \"# Perl Compress::Zlib unavailable, skipping gunzip test\"\n  fi\n   test_expect_success 'git svn gc does not change unhandled.log files' '\n-- \n1.6.6\n"},{"id":"157730","messageId":"20101209213123.GA25684@dcvr.yhbt.net","threadId":"26008","inReplyTo":"4D0133AF.40000@web.de","subject":"Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2010-12-09T21:31:23Z","receivedAt":"2010-12-09T21:31:23Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Torsten Bögershausen <tboegi@web.de> wrote:\n> Do not depend on internal implementation details of svn,\n> which right now uses perl to create a .gz file.\n> So this test case will even work in the future,\n> when svn changes its implementation.\n>\n> Signed-off-by: Torsten Bögershausen <tboegi@web.de>\n\nThanks Torsten, I needed to fix whitespace mangling from\nyour mailer to get it to apply cleanly.\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\nIt's pushed out to git://git.bogomips.org/git-svn along with an\nolder patch from Steven:\n\nSteven Walter (1):\n      git-svn: allow the mergeinfo property to be set\n\nTorsten Bögershausen (1):\n      t9143: do not fail when unhandled.log.gz is not created\n\n-- \nEric Wong\n"},{"id":"157769","messageId":"7v39q6fpvk.fsf@alter.siamese.dyndns.org","threadId":"26008","inReplyTo":"20101209213123.GA25684@dcvr.yhbt.net","subject":"Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-10T00:11:43Z","receivedAt":"2010-12-10T00:11:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong <normalperson@yhbt.net> writes:\n\n> It's pushed out to git://git.bogomips.org/git-svn along with an\n> older patch from Steven:\n>\n> Steven Walter (1):\n>       git-svn: allow the mergeinfo property to be set\n>\n> Torsten Bögershausen (1):\n>       t9143: do not fail when unhandled.log.gz is not created\n\nThanks; will pull.\n"}]}