# [PATCH] t9143: do not fail when unhandled.log.gz is not created 3 messages from 2010-12-09 to 2010-12-10. Participants: Torsten Bögershausen, Eric Wong, Junio C Hamano. Thread: https://gitlist.dev/t/26008 ## Torsten Bögershausen, 2010-12-09 19:53 Subject: [PATCH] t9143: do not fail when unhandled.log.gz is not created Message-ID: <4D0133AF.40000@web.de> URL: https://gitlist.dev/e/4D0133AF.40000%40web.de ``` Do not depend on internal implementation details of svn, which right now uses perl to create a .gz file. So this test case will even work in the future, when svn changes its implementation. Signed-off-by: Torsten Bögershausen --- t/t9143-git-svn-gc.sh | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/t/t9143-git-svn-gc.sh b/t/t9143-git-svn-gc.sh index 337ea59..4594e1a 100755 --- a/t/t9143-git-svn-gc.sh +++ b/t/t9143-git-svn-gc.sh @@ -37,13 +37,11 @@ test_expect_success 'git svn gc runs' 'git svn gc' test_expect_success 'git svn index removed' '! test -f .git/svn/refs/remotes/git-svn/index' -if perl -MCompress::Zlib -e 0 2>/dev/null +if test -r .git/svn/refs/remotes/git-svn/unhandled.log.gz then test_expect_success 'git svn gc produces a valid gzip file' ' gunzip .git/svn/refs/remotes/git-svn/unhandled.log.gz ' -else - say "# Perl Compress::Zlib unavailable, skipping gunzip test" fi test_expect_success 'git svn gc does not change unhandled.log files' ' -- 1.6.6 ``` ## Eric Wong, 2010-12-09 21:31 Subject: Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created Message-ID: <20101209213123.GA25684@dcvr.yhbt.net> URL: https://gitlist.dev/e/20101209213123.GA25684%40dcvr.yhbt.net In-Reply-To: <4D0133AF.40000@web.de> ``` Torsten Bögershausen wrote: > Do not depend on internal implementation details of svn, > which right now uses perl to create a .gz file. > So this test case will even work in the future, > when svn changes its implementation. > > Signed-off-by: Torsten Bögershausen Thanks Torsten, I needed to fix whitespace mangling from your mailer to get it to apply cleanly. Acked-by: Eric Wong It's pushed out to git://git.bogomips.org/git-svn along with an older patch from Steven: Steven Walter (1): git-svn: allow the mergeinfo property to be set Torsten Bögershausen (1): t9143: do not fail when unhandled.log.gz is not created -- Eric Wong ``` ## Junio C Hamano, 2010-12-10 00:11 Subject: Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created Message-ID: <7v39q6fpvk.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v39q6fpvk.fsf%40alter.siamese.dyndns.org In-Reply-To: <20101209213123.GA25684@dcvr.yhbt.net> ``` Eric Wong writes: > It's pushed out to git://git.bogomips.org/git-svn along with an > older patch from Steven: > > Steven Walter (1): > git-svn: allow the mergeinfo property to be set > > Torsten Bögershausen (1): > t9143: do not fail when unhandled.log.gz is not created Thanks; will pull. ```