t9112-fetch-rsync.sh breaks if cogito is located in a directory containing e.g. spaces. The test uses its own rsync replacement (localrsync) and supplies it to cg-fetch with full patch. cg-fetch doesn't quote rsync sufficiently to prevent interpreting the path to localrsync by the shell.
This bug is unlikely to be a problem in real life, but it's important to have cogito tests run properly in directories with unusual names, since it allows to catch a number of more serious problems.
Signed-off-by: Pavel Roskin <proski@gnu.org>
Show changes to cg-fetch +1 −1
diff --git a/cg-fetch b/cg-fetch index 8fa34ce..6dfd02f 100755 --- a/cg-fetch +++ b/cg-fetch @@ -102,7 +102,7 @@ get_rsync() shift fi - eval ${RSYNC:-rsync} $RSYNC_FLAGS $rsync_flags_l -v -Lr \ + eval '"${RSYNC:-rsync}"' $RSYNC_FLAGS $rsync_flags_l -v -Lr \ "$1$appenduri" "$2$appenduri" $redir | $filter return ${PIPESTATUS[0]} }
-- Regards, Pavel Roskin