git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] cg-fetch: support for active symbols in rsync path

From
PRPavel Roskin <proski@gnu.org>
Date
Nov 11, 2005, 05:49 UTC
Message-ID
<1131688169.31172.34.camel@dv>

t9112-fetch-rsync.sh breaks if cogito is located in a directory containing e.g. spaces. The test uses its own rsync replacement (localrsync) and supplies it to cg-fetch with full patch. cg-fetch doesn't quote rsync sufficiently to prevent interpreting the path to localrsync by the shell.

This bug is unlikely to be a problem in real life, but it's important to have cogito tests run properly in directories with unusual names, since it allows to catch a number of more serious problems.

Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/cg-fetch b/cg-fetch
index 8fa34ce..6dfd02f 100755
--- a/cg-fetch
+++ b/cg-fetch
@@ -102,7 +102,7 @@ get_rsync()
 		shift
 	fi
 
-	eval ${RSYNC:-rsync} $RSYNC_FLAGS $rsync_flags_l -v -Lr \
+	eval '"${RSYNC:-rsync}"' $RSYNC_FLAGS $rsync_flags_l -v -Lr \
 		"$1$appenduri" "$2$appenduri" $redir | $filter
 	return ${PIPESTATUS[0]}
 }
-- 
Regards,
Pavel Roskin
Message 1 of 1 in “cg-fetch: support for active symbols in rsync path”
  1. cg-fetch: support for active symbols in rsync pathPavel Roskin, Nov 11, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.