{"thread":{"id":"2447","subject":"[PATCH] cg-fetch: support for active symbols in rsync path","startedAt":"2005-11-11T05:49:29Z","lastAt":"2005-11-11T05:49:29Z","messageCount":1,"participants":["Pavel Roskin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"11552","messageId":"1131688169.31172.34.camel@dv","threadId":"2447","inReplyTo":null,"subject":"[PATCH] cg-fetch: support for active symbols in rsync path","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-11-11T05:49:29Z","receivedAt":"2005-11-11T05:49:29Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"t9112-fetch-rsync.sh breaks if cogito is located in a directory\ncontaining e.g. spaces.  The test uses its own rsync replacement\n(localrsync) and supplies it to cg-fetch with full patch.  cg-fetch\ndoesn't quote rsync sufficiently to prevent interpreting the path to\nlocalrsync by the shell.\n\nThis bug is unlikely to be a problem in real life, but it's important to\nhave cogito tests run properly in directories with unusual names, since\nit allows to catch a number of more serious problems.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n\ndiff --git a/cg-fetch b/cg-fetch\nindex 8fa34ce..6dfd02f 100755\n--- a/cg-fetch\n+++ b/cg-fetch\n@@ -102,7 +102,7 @@ get_rsync()\n \t\tshift\n \tfi\n \n-\teval ${RSYNC:-rsync} $RSYNC_FLAGS $rsync_flags_l -v -Lr \\\n+\teval '\"${RSYNC:-rsync}\"' $RSYNC_FLAGS $rsync_flags_l -v -Lr \\\n \t\t\"$1$appenduri\" \"$2$appenduri\" $redir | $filter\n \treturn ${PIPESTATUS[0]}\n }\n\n\n-- \nRegards,\nPavel Roskin\n"}]}