threads / patch / 24436

patchtests: rename test to work around GNU gettext bug

Subject: [PATCH] tests: rename test to work around GNU gettext bug

## tl;dr

3 messages between Jul 19, 2010 and Jul 19, 2010. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ævar Arnfjörð Bjarmason· Jul 19, 2010, 20:13 UTC · lore

Rename t0200-gettext.sh to t0200-gettext-basic.sh. Versions of GNU gettext before v0.15 (released in 2006) fail to run the test because of an old bug in gettext.sh.

To conform with the FHS gettext.sh prints a help message when it's invoked directly. To do this it checks if $0 is "gettext.sh". This check was broken before v0.15, it was checking for *\gettext.sh (to support Windows), but now correctly checks for *\\gettext.sh.

t0200-gettext-basic.sh matched the former broken check, so on systems with an old GNU gettext (like RHEL 5.4) the test simply printed:

    ./t0200-gettext.sh
    GNU gettext shell script function library version 0.14.6
    Usage: . gettext.sh
    FATAL: Unexpected exit with code 1

Which is just the gettext.sh help output:

    $ gettext.sh
    GNU gettext shell script function library version 0.17
    Usage: . gettext.sh

Change the test name to t0200-gettext-basic.sh to work around the issue.

Reported-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---

This patch is against pu. It requires the gettext series already there.

 t/{t0200-gettext.sh => t0200-gettext-basic.sh} |    0
 1 files changed, 0 insertions(+), 0 deletions(-)
 rename t/{t0200-gettext.sh => t0200-gettext-basic.sh} (100%)

Show changes to t/t0200-gettext.sh +0 −0

diff --git a/t/t0200-gettext.sh b/t/t0200-gettext-basic.sh
similarity index 100%
rename from t/t0200-gettext.sh
rename to t/t0200-gettext-basic.sh

-- 
1.7.2.rc3.125.g94e09.dirty

Ævar Arnfjörð Bjarmason· Jul 19, 2010, 20:28 UTC · re: Ævar Arnfjörð Bjarmason · lore

[PATCH v2] tests: rename test to work around GNU gettext bug

Rename t0200-gettext.sh to t0200-gettext-basic.sh. Versions of GNU gettext before v0.15 (released in 2006) fail to run the test because of an old bug in gettext.sh.

t0200-gettext.sh matched the former broken check, so on systems with an old GNU gettext (like RHEL 5.4) the test simply printed:

    ./t0200-gettext.sh
    GNU gettext shell script function library version 0.14.6
    Usage: . gettext.sh
    FATAL: Unexpected exit with code 1

Which is just the gettext.sh help output:

    $ gettext.sh
    GNU gettext shell script function library version 0.17
    Usage: . gettext.sh

Change the test name to t0200-gettext-basic.sh to work around that.

Reported-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---

Thomas Rast noted a typo in the commit message offlist. This fixes that.

 t/{t0200-gettext.sh => t0200-gettext-basic.sh} |    0
 1 files changed, 0 insertions(+), 0 deletions(-)
 rename t/{t0200-gettext.sh => t0200-gettext-basic.sh} (100%)

Show changes to t/t0200-gettext.sh +0 −0

diff --git a/t/t0200-gettext.sh b/t/t0200-gettext-basic.sh
similarity index 100%
rename from t/t0200-gettext.sh
rename to t/t0200-gettext-basic.sh

-- 
1.7.2.rc3.125.g94e09.dirty

Thomas Rast· Jul 19, 2010, 20:38 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH v2] tests: rename test to work around GNU gettext bug

Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> t0200-gettext.sh matched the former broken check, so on systems with
> an old GNU gettext (like RHEL 5.4) the test simply printed:
> 
>     ./t0200-gettext.sh
>     GNU gettext shell script function library version 0.14.6
>     Usage: . gettext.sh
>     FATAL: Unexpected exit with code 1

ACK and tested (on the RHEL5.4 that started this). Thanks for the help and fast fix!

-- 
Thomas Rast
trast@{inf,student}.ethz.ch