# [PATCH] tests: rename test to work around GNU gettext bug 3 messages from 2010-07-19 to 2010-07-19. Participants: Ævar Arnfjörð Bjarmason, Thomas Rast. Thread: https://gitlist.dev/t/24436 ## Ævar Arnfjörð Bjarmason, 2010-07-19 20:13 Subject: [PATCH] tests: rename test to work around GNU gettext bug Message-ID: <1279570409-5293-1-git-send-email-avarab@gmail.com> URL: https://gitlist.dev/e/1279570409-5293-1-git-send-email-avarab%40gmail.com ``` Rename t0200-gettext.sh to t0200-gettext-basic.sh. Versions of GNU gettext before v0.15 (released in 2006) fail to run the test because of an old bug in gettext.sh. To conform with the FHS gettext.sh prints a help message when it's invoked directly. To do this it checks if $0 is "gettext.sh". This check was broken before v0.15, it was checking for *\gettext.sh (to support Windows), but now correctly checks for *\\gettext.sh. t0200-gettext-basic.sh matched the former broken check, so on systems with an old GNU gettext (like RHEL 5.4) the test simply printed: ./t0200-gettext.sh GNU gettext shell script function library version 0.14.6 Usage: . gettext.sh FATAL: Unexpected exit with code 1 Which is just the gettext.sh help output: $ gettext.sh GNU gettext shell script function library version 0.17 Usage: . gettext.sh Change the test name to t0200-gettext-basic.sh to work around the issue. Reported-by: Thomas Rast Signed-off-by: Ævar Arnfjörð Bjarmason --- This patch is against pu. It requires the gettext series already there. t/{t0200-gettext.sh => t0200-gettext-basic.sh} | 0 1 files changed, 0 insertions(+), 0 deletions(-) rename t/{t0200-gettext.sh => t0200-gettext-basic.sh} (100%) diff --git a/t/t0200-gettext.sh b/t/t0200-gettext-basic.sh similarity index 100% rename from t/t0200-gettext.sh rename to t/t0200-gettext-basic.sh -- 1.7.2.rc3.125.g94e09.dirty ``` ## Ævar Arnfjörð Bjarmason, 2010-07-19 20:28 Subject: [PATCH v2] tests: rename test to work around GNU gettext bug Message-ID: <1279571291-5555-1-git-send-email-avarab@gmail.com> URL: https://gitlist.dev/e/1279571291-5555-1-git-send-email-avarab%40gmail.com In-Reply-To: <1279570409-5293-1-git-send-email-avarab@gmail.com> ``` Rename t0200-gettext.sh to t0200-gettext-basic.sh. Versions of GNU gettext before v0.15 (released in 2006) fail to run the test because of an old bug in gettext.sh. To conform with the FHS gettext.sh prints a help message when it's invoked directly. To do this it checks if $0 is "gettext.sh". This check was broken before v0.15, it was checking for *\gettext.sh (to support Windows), but now correctly checks for *\\gettext.sh. t0200-gettext.sh matched the former broken check, so on systems with an old GNU gettext (like RHEL 5.4) the test simply printed: ./t0200-gettext.sh GNU gettext shell script function library version 0.14.6 Usage: . gettext.sh FATAL: Unexpected exit with code 1 Which is just the gettext.sh help output: $ gettext.sh GNU gettext shell script function library version 0.17 Usage: . gettext.sh Change the test name to t0200-gettext-basic.sh to work around that. Reported-by: Thomas Rast Signed-off-by: Ævar Arnfjörð Bjarmason --- Thomas Rast noted a typo in the commit message offlist. This fixes that. t/{t0200-gettext.sh => t0200-gettext-basic.sh} | 0 1 files changed, 0 insertions(+), 0 deletions(-) rename t/{t0200-gettext.sh => t0200-gettext-basic.sh} (100%) diff --git a/t/t0200-gettext.sh b/t/t0200-gettext-basic.sh similarity index 100% rename from t/t0200-gettext.sh rename to t/t0200-gettext-basic.sh -- 1.7.2.rc3.125.g94e09.dirty ``` ## Thomas Rast, 2010-07-19 20:38 Subject: Re: [PATCH v2] tests: rename test to work around GNU gettext bug Message-ID: <201007192238.57783.trast@student.ethz.ch> URL: https://gitlist.dev/e/201007192238.57783.trast%40student.ethz.ch In-Reply-To: <1279571291-5555-1-git-send-email-avarab@gmail.com> ``` Ævar Arnfjörð Bjarmason wrote: > t0200-gettext.sh matched the former broken check, so on systems with > an old GNU gettext (like RHEL 5.4) the test simply printed: > > ./t0200-gettext.sh > GNU gettext shell script function library version 0.14.6 > Usage: . gettext.sh > FATAL: Unexpected exit with code 1 ACK and tested (on the RHEL5.4 that started this). Thanks for the help and fast fix! -- Thomas Rast trast@{inf,student}.ethz.ch ```