{"thread":{"id":"24436","subject":"[PATCH] tests: rename test to work around GNU gettext bug","startedAt":"2010-07-19T20:13:29Z","lastAt":"2010-07-19T20:38:57Z","messageCount":3,"participants":["Ævar Arnfjörð Bjarmason","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"145812","messageId":"1279570409-5293-1-git-send-email-avarab@gmail.com","threadId":"24436","inReplyTo":null,"subject":"[PATCH] tests: rename test to work around GNU gettext bug","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-19T20:13:29Z","receivedAt":"2010-07-19T20:13:29Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Rename t0200-gettext.sh to t0200-gettext-basic.sh. Versions of GNU\ngettext before v0.15 (released in 2006) fail to run the test because\nof an old bug in gettext.sh.\n\nTo conform with the FHS gettext.sh prints a help message when it's\ninvoked directly. To do this it checks if $0 is \"gettext.sh\". This\ncheck was broken before v0.15, it was checking for *\\gettext.sh (to\nsupport Windows), but now correctly checks for *\\\\gettext.sh.\n\nt0200-gettext-basic.sh matched the former broken check, so on systems\nwith an old GNU gettext (like RHEL 5.4) the test simply printed:\n\n    ./t0200-gettext.sh\n    GNU gettext shell script function library version 0.14.6\n    Usage: . gettext.sh\n    FATAL: Unexpected exit with code 1\n\nWhich is just the gettext.sh help output:\n\n    $ gettext.sh\n    GNU gettext shell script function library version 0.17\n    Usage: . gettext.sh\n\nChange the test name to t0200-gettext-basic.sh to work around the\nissue.\n\nReported-by: Thomas Rast <trast@student.ethz.ch>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nThis patch is against pu. It requires the gettext series already\nthere.\n\n t/{t0200-gettext.sh => t0200-gettext-basic.sh} |    0\n 1 files changed, 0 insertions(+), 0 deletions(-)\n rename t/{t0200-gettext.sh => t0200-gettext-basic.sh} (100%)\n\ndiff --git a/t/t0200-gettext.sh b/t/t0200-gettext-basic.sh\nsimilarity index 100%\nrename from t/t0200-gettext.sh\nrename to t/t0200-gettext-basic.sh\n-- \n1.7.2.rc3.125.g94e09.dirty\n"},{"id":"145814","messageId":"1279571291-5555-1-git-send-email-avarab@gmail.com","threadId":"24436","inReplyTo":"1279570409-5293-1-git-send-email-avarab@gmail.com","subject":"[PATCH v2] tests: rename test to work around GNU gettext bug","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-19T20:28:11Z","receivedAt":"2010-07-19T20:28:11Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Rename t0200-gettext.sh to t0200-gettext-basic.sh. Versions of GNU\ngettext before v0.15 (released in 2006) fail to run the test because\nof an old bug in gettext.sh.\n\nTo conform with the FHS gettext.sh prints a help message when it's\ninvoked directly. To do this it checks if $0 is \"gettext.sh\". This\ncheck was broken before v0.15, it was checking for *\\gettext.sh (to\nsupport Windows), but now correctly checks for *\\\\gettext.sh.\n\nt0200-gettext.sh matched the former broken check, so on systems with\nan old GNU gettext (like RHEL 5.4) the test simply printed:\n\n    ./t0200-gettext.sh\n    GNU gettext shell script function library version 0.14.6\n    Usage: . gettext.sh\n    FATAL: Unexpected exit with code 1\n\nWhich is just the gettext.sh help output:\n\n    $ gettext.sh\n    GNU gettext shell script function library version 0.17\n    Usage: . gettext.sh\n\nChange the test name to t0200-gettext-basic.sh to work around that.\n\nReported-by: Thomas Rast <trast@student.ethz.ch>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nThomas Rast noted a typo in the commit message offlist. This fixes\nthat.\n\n t/{t0200-gettext.sh => t0200-gettext-basic.sh} |    0\n 1 files changed, 0 insertions(+), 0 deletions(-)\n rename t/{t0200-gettext.sh => t0200-gettext-basic.sh} (100%)\n\ndiff --git a/t/t0200-gettext.sh b/t/t0200-gettext-basic.sh\nsimilarity index 100%\nrename from t/t0200-gettext.sh\nrename to t/t0200-gettext-basic.sh\n-- \n1.7.2.rc3.125.g94e09.dirty\n"},{"id":"145816","messageId":"201007192238.57783.trast@student.ethz.ch","threadId":"24436","inReplyTo":"1279571291-5555-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH v2] tests: rename test to work around GNU gettext bug","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2010-07-19T20:38:57Z","receivedAt":"2010-07-19T20:38:57Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Ævar Arnfjörð Bjarmason wrote:\n> t0200-gettext.sh matched the former broken check, so on systems with\n> an old GNU gettext (like RHEL 5.4) the test simply printed:\n> \n>     ./t0200-gettext.sh\n>     GNU gettext shell script function library version 0.14.6\n>     Usage: . gettext.sh\n>     FATAL: Unexpected exit with code 1\n\nACK and tested (on the RHEL5.4 that started this).  Thanks for the\nhelp and fast fix!\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"}]}