No need to check for more lines of the authentication database after found a
matching line.
---
git-cvsserver.perl | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
Show changes to git-cvsserver.perl +4 −6
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 01c5b21..fa2a11e 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -242,11 +242,10 @@ if ($state->{method} eq 'pserver') {
my $auth_ok;
open my $passwd, "<", $authdb or die $!;
while (<$passwd>) {
- if (m{^\Q$user\E:(.*)}) {
- if (crypt($user, $password) eq $1) {
- $auth_ok = 1;
- }
- };
+ if (m{^\Q$user\E:(.*)} && crypt($user, $password) eq $1) {
+ $auth_ok = 1;
+ last;
+ }
}
close $passwd;
--
1.7.2.rc1.dirty
