# [PATCH 4/4] git-cvsserver: break from loop after a successful hit

2 messages from 2010-07-03 to 2010-07-03. Participants: Áshin László, Ævar Arnfjörð Bjarmason.
Thread: https://gitlist.dev/t/24283

## Áshin László, 2010-07-03 21:24

Subject: [PATCH 4/4] git-cvsserver: break from loop after a successful hit
Message-ID: <AANLkTimPJPv0RieGQcXyJULFDcapVM74JCXcM9LU8CEQ@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTimPJPv0RieGQcXyJULFDcapVM74JCXcM9LU8CEQ%40mail.gmail.com

```
No need to check for more lines of the authentication database after found a
matching line.
---
 git-cvsserver.perl |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 01c5b21..fa2a11e 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -242,11 +242,10 @@ if ($state->{method} eq 'pserver') {
        my $auth_ok;
        open my $passwd, "<", $authdb or die $!;
        while (<$passwd>) {
-            if (m{^\Q$user\E:(.*)}) {
-                if (crypt($user, $password) eq $1) {
-                    $auth_ok = 1;
-                }
-            };
+            if (m{^\Q$user\E:(.*)} && crypt($user, $password) eq $1) {
+                $auth_ok = 1;
+                last;
+            }
        }
        close $passwd;

--
1.7.2.rc1.dirty

```

## Ævar Arnfjörð Bjarmason, 2010-07-03 22:20

Subject: Re: [PATCH 4/4] git-cvsserver: break from loop after a successful hit
Message-ID: <AANLkTikYBF7TE3i68CcX_76pLGW7M1X6xAecAGvhtb0C@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTikYBF7TE3i68CcX_76pLGW7M1X6xAecAGvhtb0C%40mail.gmail.com
In-Reply-To: <AANLkTimPJPv0RieGQcXyJULFDcapVM74JCXcM9LU8CEQ@mail.gmail.com>

```
On Sat, Jul 3, 2010 at 21:24, Áshin László <ashinlaszlo@gmail.com> wrote:
> No need to check for more lines of the authentication database after found a
> matching line.

Indeed.

Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

```