{"thread":{"id":"24283","subject":"[PATCH 4/4] git-cvsserver: break from loop after a successful hit","startedAt":"2010-07-03T21:24:26Z","lastAt":"2010-07-03T22:20:07Z","messageCount":2,"participants":["Áshin László","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"144760","messageId":"AANLkTimPJPv0RieGQcXyJULFDcapVM74JCXcM9LU8CEQ@mail.gmail.com","threadId":"24283","inReplyTo":null,"subject":"[PATCH 4/4] git-cvsserver: break from loop after a successful hit","fromName":"Áshin László","fromEmail":"ashinlaszlo@gmail.com","sentAt":"2010-07-03T21:24:26Z","receivedAt":"2010-07-03T21:24:26Z","isPatch":true,"sender":{"key":"ashinlaszlo@gmail.com","avatar":null},"body":"No need to check for more lines of the authentication database after found a\nmatching line.\n---\n git-cvsserver.perl |    9 ++++-----\n 1 files changed, 4 insertions(+), 5 deletions(-)\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex 01c5b21..fa2a11e 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -242,11 +242,10 @@ if ($state->{method} eq 'pserver') {\n        my $auth_ok;\n        open my $passwd, \"<\", $authdb or die $!;\n        while (<$passwd>) {\n-            if (m{^\\Q$user\\E:(.*)}) {\n-                if (crypt($user, $password) eq $1) {\n-                    $auth_ok = 1;\n-                }\n-            };\n+            if (m{^\\Q$user\\E:(.*)} && crypt($user, $password) eq $1) {\n+                $auth_ok = 1;\n+                last;\n+            }\n        }\n        close $passwd;\n\n--\n1.7.2.rc1.dirty\n"},{"id":"144764","messageId":"AANLkTikYBF7TE3i68CcX_76pLGW7M1X6xAecAGvhtb0C@mail.gmail.com","threadId":"24283","inReplyTo":"AANLkTimPJPv0RieGQcXyJULFDcapVM74JCXcM9LU8CEQ@mail.gmail.com","subject":"Re: [PATCH 4/4] git-cvsserver: break from loop after a successful hit","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-03T22:20:07Z","receivedAt":"2010-07-03T22:20:07Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sat, Jul 3, 2010 at 21:24, Áshin László <ashinlaszlo@gmail.com> wrote:\n> No need to check for more lines of the authentication database after found a\n> matching line.\n\nIndeed.\n\nAcked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n"}]}