threads / discuss / 24277

what is the test target of t9400-git-cvsserver-server.sh

Subject: what is the test target of t9400-git-cvsserver-server.sh

## tl;dr

3 messages between Jul 3, 2010 and Jul 3, 2010.

replies: 2people: 2as markdown or json

Áshin László· Jul 3, 2010, 17:04 UTC · lore

Hi,

t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER for the cvs client: CVS_SERVER=git-cvsserver

What is the goal of this test? To test the git-cvsserver executable found in the system (in $PATH), or the one bundled in the git source distribution? I would think that unit tests are to be run before make install, so it should test the latter. I have a patch already to fix that and I will post it in case I am right.

Regards, László ÁSHIN

Ævar Arnfjörð Bjarmason· Jul 3, 2010, 20:52 UTC · re: Áshin László · lore

Re: what is the test target of t9400-git-cvsserver-server.sh

On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:

Show 9 quoted lines

> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
> for the cvs client:
> CVS_SERVER=git-cvsserver
>
> What is the goal of this test? To test the git-cvsserver executable
> found in the system (in $PATH), or the one bundled in the git source
> distribution? I would think that unit tests are to be run before make
> install, so it should test the latter. I have a patch already to fix
> that and I will post it in case I am right.

Have you noticed that test-lib.sh sets PATH to include the git directory?

Áshin László· Jul 3, 2010, 21:28 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: what is the test target of t9400-git-cvsserver-server.sh

You are right, I don't know why it didn't work for me when I first tried. Now it does...

On Sat, Jul 3, 2010 at 22:52, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 13 quoted lines

> On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:
>> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
>> for the cvs client:
>> CVS_SERVER=git-cvsserver
>>
>> What is the goal of this test? To test the git-cvsserver executable
>> found in the system (in $PATH), or the one bundled in the git source
>> distribution? I would think that unit tests are to be run before make
>> install, so it should test the latter. I have a patch already to fix
>> that and I will post it in case I am right.
>
> Have you noticed that test-lib.sh sets PATH to include the git directory?
>