{"thread":{"id":"24277","subject":"what is the test target of t9400-git-cvsserver-server.sh","startedAt":"2010-07-03T17:04:34Z","lastAt":"2010-07-03T21:28:01Z","messageCount":3,"participants":["Áshin László","Ævar Arnfjörð Bjarmason"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"144748","messageId":"AANLkTimhp_D22jGlfkbJenYpyzLKWN6HqCyHePCOwJ50@mail.gmail.com","threadId":"24277","inReplyTo":null,"subject":"what is the test target of t9400-git-cvsserver-server.sh","fromName":"Áshin László","fromEmail":"ashinlaszlo@gmail.com","sentAt":"2010-07-03T17:04:34Z","receivedAt":"2010-07-03T17:04:34Z","isPatch":false,"sender":{"key":"ashinlaszlo@gmail.com","avatar":null},"body":"Hi,\n\nt9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER\nfor the cvs client:\nCVS_SERVER=git-cvsserver\n\nWhat is the goal of this test? To test the git-cvsserver executable\nfound in the system (in $PATH), or the one bundled in the git source\ndistribution? I would think that unit tests are to be run before make\ninstall, so it should test the latter. I have a patch already to fix\nthat and I will post it in case I am right.\n\nRegards,\nLászló ÁSHIN\n"},{"id":"144756","messageId":"AANLkTimuYhTyQmxOdKuFUujGmXDC9scHQLGMaWCxcLeG@mail.gmail.com","threadId":"24277","inReplyTo":"AANLkTimhp_D22jGlfkbJenYpyzLKWN6HqCyHePCOwJ50@mail.gmail.com","subject":"Re: what is the test target of t9400-git-cvsserver-server.sh","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-03T20:52:20Z","receivedAt":"2010-07-03T20:52:20Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:\n> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER\n> for the cvs client:\n> CVS_SERVER=git-cvsserver\n>\n> What is the goal of this test? To test the git-cvsserver executable\n> found in the system (in $PATH), or the one bundled in the git source\n> distribution? I would think that unit tests are to be run before make\n> install, so it should test the latter. I have a patch already to fix\n> that and I will post it in case I am right.\n\nHave you noticed that test-lib.sh sets PATH to include the git directory?\n"},{"id":"144761","messageId":"AANLkTilxJh18NKKDQSf-qItBLMFejAhAM30RvGeKnYQi@mail.gmail.com","threadId":"24277","inReplyTo":"AANLkTimuYhTyQmxOdKuFUujGmXDC9scHQLGMaWCxcLeG@mail.gmail.com","subject":"Re: what is the test target of t9400-git-cvsserver-server.sh","fromName":"Áshin László","fromEmail":"ashinlaszlo@gmail.com","sentAt":"2010-07-03T21:28:01Z","receivedAt":"2010-07-03T21:28:01Z","isPatch":false,"sender":{"key":"ashinlaszlo@gmail.com","avatar":null},"body":"You are right, I don't know why it didn't work for me when I first\ntried. Now it does...\n\nOn Sat, Jul 3, 2010 at 22:52, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:\n> On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:\n>> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER\n>> for the cvs client:\n>> CVS_SERVER=git-cvsserver\n>>\n>> What is the goal of this test? To test the git-cvsserver executable\n>> found in the system (in $PATH), or the one bundled in the git source\n>> distribution? I would think that unit tests are to be run before make\n>> install, so it should test the latter. I have a patch already to fix\n>> that and I will post it in case I am right.\n>\n> Have you noticed that test-lib.sh sets PATH to include the git directory?\n>\n"}]}