# what is the test target of t9400-git-cvsserver-server.sh

3 messages from 2010-07-03 to 2010-07-03. Participants: Áshin László, Ævar Arnfjörð Bjarmason.
Thread: https://gitlist.dev/t/24277

## Áshin László, 2010-07-03 17:04

Subject: what is the test target of t9400-git-cvsserver-server.sh
Message-ID: <AANLkTimhp_D22jGlfkbJenYpyzLKWN6HqCyHePCOwJ50@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTimhp_D22jGlfkbJenYpyzLKWN6HqCyHePCOwJ50%40mail.gmail.com

```
Hi,

t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
for the cvs client:
CVS_SERVER=git-cvsserver

What is the goal of this test? To test the git-cvsserver executable
found in the system (in $PATH), or the one bundled in the git source
distribution? I would think that unit tests are to be run before make
install, so it should test the latter. I have a patch already to fix
that and I will post it in case I am right.

Regards,
László ÁSHIN

```

## Ævar Arnfjörð Bjarmason, 2010-07-03 20:52

Subject: Re: what is the test target of t9400-git-cvsserver-server.sh
Message-ID: <AANLkTimuYhTyQmxOdKuFUujGmXDC9scHQLGMaWCxcLeG@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTimuYhTyQmxOdKuFUujGmXDC9scHQLGMaWCxcLeG%40mail.gmail.com
In-Reply-To: <AANLkTimhp_D22jGlfkbJenYpyzLKWN6HqCyHePCOwJ50@mail.gmail.com>

```
On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:
> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
> for the cvs client:
> CVS_SERVER=git-cvsserver
>
> What is the goal of this test? To test the git-cvsserver executable
> found in the system (in $PATH), or the one bundled in the git source
> distribution? I would think that unit tests are to be run before make
> install, so it should test the latter. I have a patch already to fix
> that and I will post it in case I am right.

Have you noticed that test-lib.sh sets PATH to include the git directory?

```

## Áshin László, 2010-07-03 21:28

Subject: Re: what is the test target of t9400-git-cvsserver-server.sh
Message-ID: <AANLkTilxJh18NKKDQSf-qItBLMFejAhAM30RvGeKnYQi@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTilxJh18NKKDQSf-qItBLMFejAhAM30RvGeKnYQi%40mail.gmail.com
In-Reply-To: <AANLkTimuYhTyQmxOdKuFUujGmXDC9scHQLGMaWCxcLeG@mail.gmail.com>

```
You are right, I don't know why it didn't work for me when I first
tried. Now it does...

On Sat, Jul 3, 2010 at 22:52, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:
>> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
>> for the cvs client:
>> CVS_SERVER=git-cvsserver
>>
>> What is the goal of this test? To test the git-cvsserver executable
>> found in the system (in $PATH), or the one bundled in the git source
>> distribution? I would think that unit tests are to be run before make
>> install, so it should test the latter. I have a patch already to fix
>> that and I will post it in case I am right.
>
> Have you noticed that test-lib.sh sets PATH to include the git directory?
>

```