threads / patch / 23521

patcht7012: Mark missing tests as TODO

Subject: [PATCH] t7012: Mark missing tests as TODO

## tl;dr

2 messages between Apr 19, 2010 and Apr 19, 2010. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Michael J Gruber· Apr 19, 2010, 08:14 UTC · lore

Currently, there are 6 tests which are not even written but are 'test_expect_failure message false'. Do not abuse test_expect_failure as a to do marker, but mark them as '#TODO' instead.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
Part of my personal war on test failures... I don't think it is helpful
to have bogus counts for failed tests.
 t/t7012-skip-worktree-writing.sh |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
Show changes to t/t7012-skip-worktree-writing.sh +6 −6
diff --git a/t/t7012-skip-worktree-writing.sh b/t/t7012-skip-worktree-writing.sh
index 8d8b1c0..582d0b5 100755
--- a/t/t7012-skip-worktree-writing.sh
+++ b/t/t7012-skip-worktree-writing.sh
@@ -136,11 +136,11 @@ test_expect_success 'git-clean, dirty case' '
 	test_cmp expected result
 '
 
-test_expect_failure 'git-apply adds file' false
-test_expect_failure 'git-apply updates file' false
-test_expect_failure 'git-apply removes file' false
-test_expect_failure 'git-mv to skip-worktree' false
-test_expect_failure 'git-mv from skip-worktree' false
-test_expect_failure 'git-checkout' false
+#TODO test_expect_failure 'git-apply adds file' false
+#TODO test_expect_failure 'git-apply updates file' false
+#TODO test_expect_failure 'git-apply removes file' false
+#TODO test_expect_failure 'git-mv to skip-worktree' false
+#TODO test_expect_failure 'git-mv from skip-worktree' false
+#TODO test_expect_failure 'git-checkout' false
 
 test_done
-- 
1.7.1.rc1.248.gcefbb
Nguyen Thai Ngoc Duy· Apr 19, 2010, 08:20 UTC · re: Michael J Gruber · lore

Re: [PATCH] t7012: Mark missing tests as TODO

2010/4/19 Michael J Gruber <git@drmicha.warpmail.net>:
> Currently, there are 6 tests which are not even written but are
> 'test_expect_failure message false'.
> Do not abuse test_expect_failure as a to do marker, but mark them as
> '#TODO' instead.
Ack.  Need to write those tests soon.
-- 
Duy

← back to recent threads