# [PATCH] t7012: Mark missing tests as TODO 2 messages from 2010-04-19 to 2010-04-19. Participants: Michael J Gruber, Nguyen Thai Ngoc Duy. Thread: https://gitlist.dev/t/23521 ## Michael J Gruber, 2010-04-19 08:14 Subject: [PATCH] t7012: Mark missing tests as TODO Message-ID: <1584248d122ac952e6c9f4b4243b23c32f23aa3b.1271664768.git.git@drmicha.warpmail.net> URL: https://gitlist.dev/e/1584248d122ac952e6c9f4b4243b23c32f23aa3b.1271664768.git.git%40drmicha.warpmail.net ``` Currently, there are 6 tests which are not even written but are 'test_expect_failure message false'. Do not abuse test_expect_failure as a to do marker, but mark them as '#TODO' instead. Signed-off-by: Michael J Gruber --- Part of my personal war on test failures... I don't think it is helpful to have bogus counts for failed tests. t/t7012-skip-worktree-writing.sh | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/t/t7012-skip-worktree-writing.sh b/t/t7012-skip-worktree-writing.sh index 8d8b1c0..582d0b5 100755 --- a/t/t7012-skip-worktree-writing.sh +++ b/t/t7012-skip-worktree-writing.sh @@ -136,11 +136,11 @@ test_expect_success 'git-clean, dirty case' ' test_cmp expected result ' -test_expect_failure 'git-apply adds file' false -test_expect_failure 'git-apply updates file' false -test_expect_failure 'git-apply removes file' false -test_expect_failure 'git-mv to skip-worktree' false -test_expect_failure 'git-mv from skip-worktree' false -test_expect_failure 'git-checkout' false +#TODO test_expect_failure 'git-apply adds file' false +#TODO test_expect_failure 'git-apply updates file' false +#TODO test_expect_failure 'git-apply removes file' false +#TODO test_expect_failure 'git-mv to skip-worktree' false +#TODO test_expect_failure 'git-mv from skip-worktree' false +#TODO test_expect_failure 'git-checkout' false test_done -- 1.7.1.rc1.248.gcefbb ``` ## Nguyen Thai Ngoc Duy, 2010-04-19 08:20 Subject: Re: [PATCH] t7012: Mark missing tests as TODO Message-ID: URL: https://gitlist.dev/e/t2wfcaeb9bf1004190120k6cf584b4m1e38c0f90461fd3e%40mail.gmail.com In-Reply-To: <1584248d122ac952e6c9f4b4243b23c32f23aa3b.1271664768.git.git@drmicha.warpmail.net> ``` 2010/4/19 Michael J Gruber : > Currently, there are 6 tests which are not even written but are > 'test_expect_failure message false'. > Do not abuse test_expect_failure as a to do marker, but mark them as > '#TODO' instead. Ack. Need to write those tests soon. -- Duy ```