{"thread":{"id":"23521","subject":"[PATCH] t7012: Mark missing tests as TODO","startedAt":"2010-04-19T08:14:32Z","lastAt":"2010-04-19T08:20:08Z","messageCount":2,"participants":["Michael J Gruber","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"139877","messageId":"1584248d122ac952e6c9f4b4243b23c32f23aa3b.1271664768.git.git@drmicha.warpmail.net","threadId":"23521","inReplyTo":null,"subject":"[PATCH] t7012: Mark missing tests as TODO","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2010-04-19T08:14:32Z","receivedAt":"2010-04-19T08:14:32Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Currently, there are 6 tests which are not even written but are\n'test_expect_failure message false'.\nDo not abuse test_expect_failure as a to do marker, but mark them as\n'#TODO' instead.\n\nSigned-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n---\nPart of my personal war on test failures... I don't think it is helpful\nto have bogus counts for failed tests.\n\n t/t7012-skip-worktree-writing.sh |   12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t7012-skip-worktree-writing.sh b/t/t7012-skip-worktree-writing.sh\nindex 8d8b1c0..582d0b5 100755\n--- a/t/t7012-skip-worktree-writing.sh\n+++ b/t/t7012-skip-worktree-writing.sh\n@@ -136,11 +136,11 @@ test_expect_success 'git-clean, dirty case' '\n \ttest_cmp expected result\n '\n \n-test_expect_failure 'git-apply adds file' false\n-test_expect_failure 'git-apply updates file' false\n-test_expect_failure 'git-apply removes file' false\n-test_expect_failure 'git-mv to skip-worktree' false\n-test_expect_failure 'git-mv from skip-worktree' false\n-test_expect_failure 'git-checkout' false\n+#TODO test_expect_failure 'git-apply adds file' false\n+#TODO test_expect_failure 'git-apply updates file' false\n+#TODO test_expect_failure 'git-apply removes file' false\n+#TODO test_expect_failure 'git-mv to skip-worktree' false\n+#TODO test_expect_failure 'git-mv from skip-worktree' false\n+#TODO test_expect_failure 'git-checkout' false\n \n test_done\n-- \n1.7.1.rc1.248.gcefbb\n"},{"id":"139879","messageId":"t2wfcaeb9bf1004190120k6cf584b4m1e38c0f90461fd3e@mail.gmail.com","threadId":"23521","inReplyTo":"1584248d122ac952e6c9f4b4243b23c32f23aa3b.1271664768.git.git@drmicha.warpmail.net","subject":"Re: [PATCH] t7012: Mark missing tests as TODO","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2010-04-19T08:20:08Z","receivedAt":"2010-04-19T08:20:08Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"2010/4/19 Michael J Gruber <git@drmicha.warpmail.net>:\n> Currently, there are 6 tests which are not even written but are\n> 'test_expect_failure message false'.\n> Do not abuse test_expect_failure as a to do marker, but mark them as\n> '#TODO' instead.\n\nAck.  Need to write those tests soon.\n-- \nDuy\n"}]}