{"thread":{"id":"23350","subject":"[PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS","startedAt":"2010-04-06T03:14:20Z","lastAt":"2010-04-06T06:06:54Z","messageCount":2,"participants":["Matt McCutchen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"138698","messageId":"1270523660.3648.7.camel@mattlaptop2.local","threadId":"23350","inReplyTo":null,"subject":"[PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS","fromName":"Matt McCutchen","fromEmail":"matt@mattmccutchen.net","sentAt":"2010-04-06T03:14:20Z","receivedAt":"2010-04-06T03:14:20Z","isPatch":true,"sender":{"key":"matt@mattmccutchen.net","avatar":"https://avatars.githubusercontent.com/u/8885753?v=4"},"body":"-Wall cleanliness is an intended property of the codebase, so -Wall\nshould be on by default even if the user's CFLAGS doesn't include it\n(e.g., the AC_PROG_CC configure test won't include it).\n---\n\nThoughts?  Is there a problem with -Wall being GNU-specific?\n\n Makefile |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 7c616f8..88f9b47 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -241,7 +241,7 @@ endif\n \n # CFLAGS and LDFLAGS are for the users to override from the command line.\n \n-CFLAGS = -g -O2 -Wall\n+CFLAGS = -g -O2\n LDFLAGS =\n ALL_CFLAGS = $(CFLAGS)\n ALL_LDFLAGS = $(LDFLAGS)\n@@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__\n # Those must not be GNU-specific; they are shared with perl/ which may\n # be built by a different compiler. (Note that this is an artifact now\n # but it still might be nice to keep that distinction.)\n-BASIC_CFLAGS = -I.\n+BASIC_CFLAGS = -Wall -I.\n BASIC_LDFLAGS =\n \n # Guard against environment variables\n-- \n1.7.0.2.288.gb0894e\n"},{"id":"138712","messageId":"7v6345ktc1.fsf@alter.siamese.dyndns.org","threadId":"23350","inReplyTo":"1270523660.3648.7.camel@mattlaptop2.local","subject":"Re: [PATCH] Makefile: move -Wall from CFLAGS to BASIC_CFLAGS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-04-06T06:06:54Z","receivedAt":"2010-04-06T06:06:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matt McCutchen <matt@mattmccutchen.net> writes:\n\n> -Wall cleanliness is an intended property of the codebase, so -Wall\n> should be on by default even if the user's CFLAGS doesn't include it\n> (e.g., the AC_PROG_CC configure test won't include it).\n> ---\n>\n> Thoughts?  Is there a problem with -Wall being GNU-specific?\n\nI think you answered yourself very well.\n\n> @@ -308,7 +308,7 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__\n>  # Those must not be GNU-specific; they are shared with perl/ which may\n>  # be built by a different compiler. (Note that this is an artifact now\n>  # but it still might be nice to keep that distinction.)\n> -BASIC_CFLAGS = -I.\n> +BASIC_CFLAGS = -Wall -I.\n>  BASIC_LDFLAGS =\n\nIt still talks about perl/ back from the days when we used to have some .xs\nstuff, but the principle still should apply.\n"}]}