threads / rfc / 23005

[RFC] Gitweb: include minified version of js and css files in the repo

Subject: [RFC] Gitweb: include minified version of js and css files in the repo

## tl;dr

3 messages between Mar 13, 2010 and Mar 14, 2010.

replies: 2people: 3as markdown or json

Mark Rada· Mar 13, 2010, 04:31 UTC · lore

Hi git devs,

I was catching up on the changes to gitweb changes in the last little while and I noticed an option to pass gitweb.js through a minifier during the make execution, which I thought was pretty cool.

However, I was wondering if there were any reasons why the minified version of the javascript code was not distributed in the git repository? It seems like you are leaving that effort to be duplicated a lot by people who compile git themselves.

— Mark Rada markrada26@gmail.com

Jakub Narebski· Mar 13, 2010, 08:26 UTC · re: Mark Rada · lore

Re: [RFC] Gitweb: include minified version of js and css files in the repo

Mark Rada <markrada26@gmail.com> writes:

Show 10 quoted lines

> I was catching up on the changes to gitweb changes in the
> last little while and I noticed an option to pass gitweb.js
> through a minifier during the make execution, which I thought
> was pretty cool. 
> 
> However, I was wondering if there were any reasons why the
> minified version of the javascript code was not distributed
> in the git repository? It seems like you are leaving that
> effort to be duplicated a lot by people who compile git
> themselves.

The reason is that one should not include *generated* files in version control. We do not include ./configure script (from configure.ac), we do not include gitweb.min.js (from gitweb.js).

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Miklos Vajna· Mar 14, 2010, 13:22 UTC · re: Jakub Narebski · lore

Re: [RFC] Gitweb: include minified version of js and css files in the repo

On Sat, Mar 13, 2010 at 12:26:51AM -0800, Jakub Narebski <jnareb@gmail.com> wrote:

> The reason is that one should not include *generated* files in
> version control.  We do not include ./configure script (from
> configure.ac), we do not include gitweb.min.js (from gitweb.js).

Though maybe it would be handy to document what a sane default value for JSMIN could be? (Provided that the user don't set it to empty what the real default is.)