{"thread":{"id":"23005","subject":"[RFC] Gitweb: include minified version of js and css files in the repo","startedAt":"2010-03-13T04:31:25Z","lastAt":"2010-03-14T13:22:30Z","messageCount":3,"participants":["Mark Rada","Jakub Narebski","Miklos Vajna"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"136695","messageId":"1B527F20-CF6C-451B-9C6E-1BE74992354D@gmail.com","threadId":"23005","inReplyTo":null,"subject":"[RFC] Gitweb: include minified version of js and css files in the repo","fromName":"Mark Rada","fromEmail":"markrada26@gmail.com","sentAt":"2010-03-13T04:31:25Z","receivedAt":"2010-03-13T04:31:25Z","isPatch":false,"sender":{"key":"markrada26@gmail.com","avatar":"https://gravatar.com/avatar/01650ee0e05cc7d0d23b4fc6163279a6c09a4dada1ed9a04ffadbd2c6a347170?d=mp&s=160"},"body":"Hi git devs,\n\nI was catching up on the changes to gitweb changes in the\nlast little while and I noticed an option to pass gitweb.js\nthrough a minifier during the make execution, which I thought\nwas pretty cool. \n\nHowever, I was wondering if there were any reasons why the\nminified version of the javascript code was not distributed\nin the git repository? It seems like you are leaving that\neffort to be duplicated a lot by people who compile git\nthemselves.\n\n—\nMark Rada\nmarkrada26@gmail.com\n"},{"id":"136713","messageId":"m3d3z8lj9x.fsf@localhost.localdomain","threadId":"23005","inReplyTo":"1B527F20-CF6C-451B-9C6E-1BE74992354D@gmail.com","subject":"Re: [RFC] Gitweb: include minified version of js and css files in the repo","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-03-13T08:26:51Z","receivedAt":"2010-03-13T08:26:51Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Mark Rada <markrada26@gmail.com> writes:\n\n> I was catching up on the changes to gitweb changes in the\n> last little while and I noticed an option to pass gitweb.js\n> through a minifier during the make execution, which I thought\n> was pretty cool. \n> \n> However, I was wondering if there were any reasons why the\n> minified version of the javascript code was not distributed\n> in the git repository? It seems like you are leaving that\n> effort to be duplicated a lot by people who compile git\n> themselves.\n\nThe reason is that one should not include *generated* files in\nversion control.  We do not include ./configure script (from\nconfigure.ac), we do not include gitweb.min.js (from gitweb.js).\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"136759","messageId":"20100314132230.GK27414@genesis.frugalware.org","threadId":"23005","inReplyTo":"m3d3z8lj9x.fsf@localhost.localdomain","subject":"Re: [RFC] Gitweb: include minified version of js and css files in the repo","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2010-03-14T13:22:30Z","receivedAt":"2010-03-14T13:22:30Z","isPatch":false,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Sat, Mar 13, 2010 at 12:26:51AM -0800, Jakub Narebski <jnareb@gmail.com> wrote:\n> The reason is that one should not include *generated* files in\n> version control.  We do not include ./configure script (from\n> configure.ac), we do not include gitweb.min.js (from gitweb.js).\n\nThough maybe it would be handy to document what a sane default value for\nJSMIN could be? (Provided that the user don't set it to empty what the\nreal default is.)\n"}]}