# [RFC] Gitweb: include minified version of js and css files in the repo 3 messages from 2010-03-13 to 2010-03-14. Participants: Mark Rada, Jakub Narebski, Miklos Vajna. Thread: https://gitlist.dev/t/23005 ## Mark Rada, 2010-03-13 04:31 Subject: [RFC] Gitweb: include minified version of js and css files in the repo Message-ID: <1B527F20-CF6C-451B-9C6E-1BE74992354D@gmail.com> URL: https://gitlist.dev/e/1B527F20-CF6C-451B-9C6E-1BE74992354D%40gmail.com ``` Hi git devs, I was catching up on the changes to gitweb changes in the last little while and I noticed an option to pass gitweb.js through a minifier during the make execution, which I thought was pretty cool. However, I was wondering if there were any reasons why the minified version of the javascript code was not distributed in the git repository? It seems like you are leaving that effort to be duplicated a lot by people who compile git themselves. — Mark Rada markrada26@gmail.com ``` ## Jakub Narebski, 2010-03-13 08:26 Subject: Re: [RFC] Gitweb: include minified version of js and css files in the repo Message-ID: URL: https://gitlist.dev/e/m3d3z8lj9x.fsf%40localhost.localdomain In-Reply-To: <1B527F20-CF6C-451B-9C6E-1BE74992354D@gmail.com> ``` Mark Rada writes: > I was catching up on the changes to gitweb changes in the > last little while and I noticed an option to pass gitweb.js > through a minifier during the make execution, which I thought > was pretty cool. > > However, I was wondering if there were any reasons why the > minified version of the javascript code was not distributed > in the git repository? It seems like you are leaving that > effort to be duplicated a lot by people who compile git > themselves. The reason is that one should not include *generated* files in version control. We do not include ./configure script (from configure.ac), we do not include gitweb.min.js (from gitweb.js). -- Jakub Narebski Poland ShadeHawk on #git ``` ## Miklos Vajna, 2010-03-14 13:22 Subject: Re: [RFC] Gitweb: include minified version of js and css files in the repo Message-ID: <20100314132230.GK27414@genesis.frugalware.org> URL: https://gitlist.dev/e/20100314132230.GK27414%40genesis.frugalware.org In-Reply-To: ``` On Sat, Mar 13, 2010 at 12:26:51AM -0800, Jakub Narebski wrote: > The reason is that one should not include *generated* files in > version control. We do not include ./configure script (from > configure.ac), we do not include gitweb.min.js (from gitweb.js). Though maybe it would be handy to document what a sane default value for JSMIN could be? (Provided that the user don't set it to empty what the real default is.) ```