threads / patch / 22819

patcht3301-notes: insert a shbang line in ./fake_editor.sh

Subject: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

## tl;dr

4 messages between Feb 25, 2010 and Feb 25, 2010. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Johannes Sixt· Feb 25, 2010, 10:39 UTC · lore
From: Johannes Sixt <j6t@kdbg.org>

This is required on Windows because git-notes is now a built-in rather than a shell script.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 t/t3301-notes.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to t/t3301-notes.sh +1 −0
diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 90178f9..37b9687 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -8,6 +8,7 @@ test_description='Test commit notes'
 . ./test-lib.sh

 cat > fake_editor.sh << \EOF
+#!/bin/sh
 echo "$MSG" > "$1"
 echo "$MSG" >& 2
 EOF

-- 
1.7.0.1285.g1a907.dirty
Johan Herland· Feb 25, 2010, 11:31 UTC · re: Johannes Sixt · lore

Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

On Thursday 25 February 2010, Johannes Sixt wrote:
Show 6 quoted lines
> From: Johannes Sixt <j6t@kdbg.org>
> 
> This is required on Windows because git-notes is now a built-in
> rather than a shell script.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Johan Herland <johan@herland.net>
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Junio C Hamano· Feb 25, 2010, 16:42 UTC · re: Johannes Sixt · lore

Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

Johannes Sixt <j.sixt@viscovery.net> writes:
Show 12 quoted lines
> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
> index 90178f9..37b9687 100755
> --- a/t/t3301-notes.sh
> +++ b/t/t3301-notes.sh
> @@ -8,6 +8,7 @@ test_description='Test commit notes'
>  . ./test-lib.sh
>
>  cat > fake_editor.sh << \EOF
> +#!/bin/sh
>  echo "$MSG" > "$1"
>  echo "$MSG" >& 2
>  EOF
Thanks.
Shouldn't that be "#!$SHELL_PATH", though?
Johannes Sixt· Feb 25, 2010, 20:17 UTC · re: Junio C Hamano · lore

Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

Junio C Hamano schrieb:
> Shouldn't that be "#!$SHELL_PATH", though?

It doesn't matter, but the change would be larger because we do not want to expand $MSG.

-- Hannes

← back to recent threads