# [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

4 messages from 2010-02-25 to 2010-02-25. Participants: Johannes Sixt, Johan Herland, Junio C Hamano.
Thread: https://gitlist.dev/t/22819

## Johannes Sixt, 2010-02-25 10:39

Subject: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
Message-ID: <4B865376.9030209@viscovery.net>
URL: https://gitlist.dev/e/4B865376.9030209%40viscovery.net

```
From: Johannes Sixt <j6t@kdbg.org>

This is required on Windows because git-notes is now a built-in
rather than a shell script.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 t/t3301-notes.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 90178f9..37b9687 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -8,6 +8,7 @@ test_description='Test commit notes'
 . ./test-lib.sh

 cat > fake_editor.sh << \EOF
+#!/bin/sh
 echo "$MSG" > "$1"
 echo "$MSG" >& 2
 EOF
-- 
1.7.0.1285.g1a907.dirty

```

## Johan Herland, 2010-02-25 11:31

Subject: Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
Message-ID: <201002251231.43028.johan@herland.net>
URL: https://gitlist.dev/e/201002251231.43028.johan%40herland.net
In-Reply-To: <4B865376.9030209@viscovery.net>

```
On Thursday 25 February 2010, Johannes Sixt wrote:
> From: Johannes Sixt <j6t@kdbg.org>
> 
> This is required on Windows because git-notes is now a built-in
> rather than a shell script.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>

Acked-by: Johan Herland <johan@herland.net>

-- 
Johan Herland, <johan@herland.net>
www.herland.net

```

## Junio C Hamano, 2010-02-25 16:42

Subject: Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
Message-ID: <7v3a0pcln4.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v3a0pcln4.fsf%40alter.siamese.dyndns.org
In-Reply-To: <4B865376.9030209@viscovery.net>

```
Johannes Sixt <j.sixt@viscovery.net> writes:

> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
> index 90178f9..37b9687 100755
> --- a/t/t3301-notes.sh
> +++ b/t/t3301-notes.sh
> @@ -8,6 +8,7 @@ test_description='Test commit notes'
>  . ./test-lib.sh
>
>  cat > fake_editor.sh << \EOF
> +#!/bin/sh
>  echo "$MSG" > "$1"
>  echo "$MSG" >& 2
>  EOF

Thanks.

Shouldn't that be "#!$SHELL_PATH", though?

```

## Johannes Sixt, 2010-02-25 20:17

Subject: Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh
Message-ID: <4B86DAE8.2060107@viscovery.net>
URL: https://gitlist.dev/e/4B86DAE8.2060107%40viscovery.net
In-Reply-To: <7v3a0pcln4.fsf@alter.siamese.dyndns.org>

```
Junio C Hamano schrieb:
> Shouldn't that be "#!$SHELL_PATH", though?

It doesn't matter, but the change would be larger because we do not
want to expand $MSG.

-- Hannes

```