{"thread":{"id":"22819","subject":"[PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh","startedAt":"2010-02-25T10:39:50Z","lastAt":"2010-02-25T20:17:44Z","messageCount":4,"participants":["Johannes Sixt","Johan Herland","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"135669","messageId":"4B865376.9030209@viscovery.net","threadId":"22819","inReplyTo":null,"subject":"[PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2010-02-25T10:39:50Z","receivedAt":"2010-02-25T10:39:50Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"From: Johannes Sixt <j6t@kdbg.org>\n\nThis is required on Windows because git-notes is now a built-in\nrather than a shell script.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n t/t3301-notes.sh |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t3301-notes.sh b/t/t3301-notes.sh\nindex 90178f9..37b9687 100755\n--- a/t/t3301-notes.sh\n+++ b/t/t3301-notes.sh\n@@ -8,6 +8,7 @@ test_description='Test commit notes'\n . ./test-lib.sh\n\n cat > fake_editor.sh << \\EOF\n+#!/bin/sh\n echo \"$MSG\" > \"$1\"\n echo \"$MSG\" >& 2\n EOF\n-- \n1.7.0.1285.g1a907.dirty\n"},{"id":"135672","messageId":"201002251231.43028.johan@herland.net","threadId":"22819","inReplyTo":"4B865376.9030209@viscovery.net","subject":"Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2010-02-25T11:31:42Z","receivedAt":"2010-02-25T11:31:42Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"On Thursday 25 February 2010, Johannes Sixt wrote:\n> From: Johannes Sixt <j6t@kdbg.org>\n> \n> This is required on Windows because git-notes is now a built-in\n> rather than a shell script.\n> \n> Signed-off-by: Johannes Sixt <j6t@kdbg.org>\n\nAcked-by: Johan Herland <johan@herland.net>\n\n-- \nJohan Herland, <johan@herland.net>\nwww.herland.net\n"},{"id":"135679","messageId":"7v3a0pcln4.fsf@alter.siamese.dyndns.org","threadId":"22819","inReplyTo":"4B865376.9030209@viscovery.net","subject":"Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-02-25T16:42:23Z","receivedAt":"2010-02-25T16:42:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt <j.sixt@viscovery.net> writes:\n\n> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh\n> index 90178f9..37b9687 100755\n> --- a/t/t3301-notes.sh\n> +++ b/t/t3301-notes.sh\n> @@ -8,6 +8,7 @@ test_description='Test commit notes'\n>  . ./test-lib.sh\n>\n>  cat > fake_editor.sh << \\EOF\n> +#!/bin/sh\n>  echo \"$MSG\" > \"$1\"\n>  echo \"$MSG\" >& 2\n>  EOF\n\nThanks.\n\nShouldn't that be \"#!$SHELL_PATH\", though?\n"},{"id":"135692","messageId":"4B86DAE8.2060107@viscovery.net","threadId":"22819","inReplyTo":"7v3a0pcln4.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2010-02-25T20:17:44Z","receivedAt":"2010-02-25T20:17:44Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Junio C Hamano schrieb:\n> Shouldn't that be \"#!$SHELL_PATH\", though?\n\nIt doesn't matter, but the change would be larger because we do not\nwant to expand $MSG.\n\n-- Hannes\n"}]}