threads / patch / 21206

patchgit-gui: Fixed _main window_ for screen height equal 600 px

Subject: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px

## tl;dr

4 messages between Oct 12, 2009 and Oct 12, 2009. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Vietor Liu· Oct 12, 2009, 06:33 UTC · lore

When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The _main window_ should be hide the _Push button_ and _Status bar_.

Signed-off-by: Vietor Liu <vietor@vxwo.org>
---
 git-gui.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-gui.sh +1 −1
diff --git a/git-gui.sh b/git-gui.sh
index 09b2720..037a1f2 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body
 set ui_diff .vpane.lower.diff.body.t
 text $ui_diff -background white -foreground black \
 	-borderwidth 0 \
-	-width 80 -height 15 -wrap none \
+	-width 80 -height 5 -wrap none \
 	-font font_diff \
 	-xscrollcommand {.vpane.lower.diff.body.sbx set} \
 	-yscrollcommand {.vpane.lower.diff.body.sby set} \

-- 
1.6.5
Johannes Schindelin· Oct 12, 2009, 07:35 UTC · re: Vietor Liu · lore

Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px

Hi,
On Mon, 12 Oct 2009, Vietor Liu wrote:
> When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The
> _main window_ should be hide the _Push button_ and _Status bar_.
Your commit message disagrees with the patch:
Show 6 quoted lines
>  set ui_diff .vpane.lower.diff.body.t
>  text $ui_diff -background white -foreground black \
>  	-borderwidth 0 \
> -	-width 80 -height 15 -wrap none \
> +	-width 80 -height 5 -wrap none \
>  	-font font_diff \
So what you _actually_ do is reduce the space for the diff, no?

Ciao, Dscho

Vietor Liu· Oct 12, 2009, 08:23 UTC · re: Johannes Schindelin · lore

Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px

On Mon, 2009-10-12 at 09:35 +0200, Johannes Schindelin wrote:
>  
> So what you _actually_ do is reduce the space for the diff, no?
>

Yes. The _main window_ support auto resize. I was tested some way, only modify _diff body_ space could work. The _diff body_ is part of _main window_. 

Whether modify the commit message?
Shawn O. Pearce· Oct 12, 2009, 14:34 UTC · re: Vietor Liu · lore

Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px

Vietor Liu <vietor@vxwo.org> wrote:
> On Mon, 2009-10-12 at 09:35 +0200, Johannes Schindelin wrote:
> >  
> > So what you _actually_ do is reduce the space for the diff, no?
Dscho, I think what's happening is he is shrinking the minimum height
of the diff pane.  By allowing it to be shorter he is trading diff
pane space in order to make room for the fixed height commit message
area below it.
Show 6 quoted lines
> Yes. 
> The _main window_ support auto resize. I was tested some way, only
> modify _diff body_ space could work. The _diff body_ is part of _main
> window_. 
> 
> Whether modify the commit message?

Yes, please modify the commit message. The message does not clearly state what is occurring here, which is why Dsco had an issue.

Really you are trying to adjust the minimum height of the diff pane, which is resizable, so that it can use less vertical height, allowing the overall window to be shorter and still display the entire commit pane.

Also, I find your use of underscores around widget names to be very difficult to read. I don't see a reason for it in the commit message.

-- 
Shawn.

← back to recent threads