Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 12, 2009, 14:34 UTC
Message-ID: <20091012143418.GK9261@spearce.org>
In-Reply-To: <1255335812.2326.20.camel@localhost.localdomain>

Vietor Liu <vietor@vxwo.org> wrote:

> On Mon, 2009-10-12 at 09:35 +0200, Johannes Schindelin wrote:
> >  
> > So what you _actually_ do is reduce the space for the diff, no?

Dscho, I think what's happening is he is shrinking the minimum height
of the diff pane.  By allowing it to be shorter he is trading diff
pane space in order to make room for the fixed height commit message
area below it.

Show 6 quoted lines

> Yes. 
> The _main window_ support auto resize. I was tested some way, only
> modify _diff body_ space could work. The _diff body_ is part of _main
> window_. 
> 
> Whether modify the commit message?

Yes, please modify the commit message. The message does not clearly state what is occurring here, which is why Dsco had an issue.

Really you are trying to adjust the minimum height of the diff pane, which is resizable, so that it can use less vertical height, allowing the overall window to be shorter and still display the entire commit pane.

Also, I find your use of underscores around widget names to be very difficult to read. I don't see a reason for it in the commit message.

-- 
Shawn.