{"thread":{"id":"21206","subject":"[PATCH] git-gui: Fixed _main window_ for screen height equal 600 px","startedAt":"2009-10-12T06:33:14Z","lastAt":"2009-10-12T14:34:18Z","messageCount":4,"participants":["Vietor Liu","Johannes Schindelin","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"124673","messageId":"1255329194-2757-1-git-send-email-vietor@vxwo.org","threadId":"21206","inReplyTo":null,"subject":"[PATCH] git-gui: Fixed _main window_ for screen height equal 600 px","fromName":"Vietor Liu","fromEmail":"vietor@vxwo.org","sentAt":"2009-10-12T06:33:14Z","receivedAt":"2009-10-12T06:33:14Z","isPatch":true,"sender":{"key":"vietor@vxwo.org","avatar":"https://gravatar.com/avatar/5aec20a4fda090db11446ebfef48ef01e702e5cef0710640a676ccbfce1f4fe3?d=mp&s=160"},"body":"When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The\n_main window_ should be hide the _Push button_ and _Status bar_.\n\nSigned-off-by: Vietor Liu <vietor@vxwo.org>\n---\n git-gui.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex 09b2720..037a1f2 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -3083,7 +3083,7 @@ frame .vpane.lower.diff.body\n set ui_diff .vpane.lower.diff.body.t\n text $ui_diff -background white -foreground black \\\n \t-borderwidth 0 \\\n-\t-width 80 -height 15 -wrap none \\\n+\t-width 80 -height 5 -wrap none \\\n \t-font font_diff \\\n \t-xscrollcommand {.vpane.lower.diff.body.sbx set} \\\n \t-yscrollcommand {.vpane.lower.diff.body.sby set} \\\n-- \n1.6.5\n"},{"id":"124677","messageId":"alpine.DEB.1.00.0910120934420.4985@pacific.mpi-cbg.de","threadId":"21206","inReplyTo":"1255329194-2757-1-git-send-email-vietor@vxwo.org","subject":"Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-10-12T07:35:44Z","receivedAt":"2009-10-12T07:35:44Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 12 Oct 2009, Vietor Liu wrote:\n\n> When the screen height equal 600 px(e.g. Asus EeePC 1024x600), The\n> _main window_ should be hide the _Push button_ and _Status bar_.\n\nYour commit message disagrees with the patch:\n\n>  set ui_diff .vpane.lower.diff.body.t\n>  text $ui_diff -background white -foreground black \\\n>  \t-borderwidth 0 \\\n> -\t-width 80 -height 15 -wrap none \\\n> +\t-width 80 -height 5 -wrap none \\\n>  \t-font font_diff \\\n\nSo what you _actually_ do is reduce the space for the diff, no?\n\nCiao,\nDscho\n"},{"id":"124679","messageId":"1255335812.2326.20.camel@localhost.localdomain","threadId":"21206","inReplyTo":"alpine.DEB.1.00.0910120934420.4985@pacific.mpi-cbg.de","subject":"Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px","fromName":"Vietor Liu","fromEmail":"vietor@vxwo.org","sentAt":"2009-10-12T08:23:32Z","receivedAt":"2009-10-12T08:23:32Z","isPatch":true,"sender":{"key":"vietor@vxwo.org","avatar":"https://gravatar.com/avatar/5aec20a4fda090db11446ebfef48ef01e702e5cef0710640a676ccbfce1f4fe3?d=mp&s=160"},"body":"On Mon, 2009-10-12 at 09:35 +0200, Johannes Schindelin wrote:\n>  \n> So what you _actually_ do is reduce the space for the diff, no?\n>\n\nYes. \nThe _main window_ support auto resize. I was tested some way, only\nmodify _diff body_ space could work. The _diff body_ is part of _main\nwindow_. \n\nWhether modify the commit message? \n"},{"id":"124704","messageId":"20091012143418.GK9261@spearce.org","threadId":"21206","inReplyTo":"1255335812.2326.20.camel@localhost.localdomain","subject":"Re: [PATCH] git-gui: Fixed _main window_ for screen height equal 600 px","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2009-10-12T14:34:18Z","receivedAt":"2009-10-12T14:34:18Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Vietor Liu <vietor@vxwo.org> wrote:\n> On Mon, 2009-10-12 at 09:35 +0200, Johannes Schindelin wrote:\n> >  \n> > So what you _actually_ do is reduce the space for the diff, no?\n\nDscho, I think what's happening is he is shrinking the minimum height\nof the diff pane.  By allowing it to be shorter he is trading diff\npane space in order to make room for the fixed height commit message\narea below it.\n \n> Yes. \n> The _main window_ support auto resize. I was tested some way, only\n> modify _diff body_ space could work. The _diff body_ is part of _main\n> window_. \n> \n> Whether modify the commit message? \n\nYes, please modify the commit message.  The message does not clearly\nstate what is occurring here, which is why Dsco had an issue.\n\nReally you are trying to adjust the minimum height of the diff\npane, which is resizable, so that it can use less vertical height,\nallowing the overall window to be shorter and still display the\nentire commit pane.\n\nAlso, I find your use of underscores around widget names to be\nvery difficult to read.  I don't see a reason for it in the commit\nmessage.\n\n-- \nShawn.\n"}]}