threads / patch / 21094

patchsend-email: fix mutt regex for grouped aliases

Subject: [PATCH] send-email: fix mutt regex for grouped aliases

## tl;dr

6 messages between Sep 30, 2009 and Oct 1, 2009. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Felipe Contreras· Sep 30, 2009, 00:08 UTC · lore

For example: alias -group friends foo Foo Bar <foo@bar.com>

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-send-email.perl +1 −1
diff --git a/git-send-email.perl b/git-send-email.perl
index 0700d80..ec43a5e 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -401,7 +401,7 @@ my %aliases;
 my %parse_alias = (
 	# multiline formats can be supported in the future
 	mutt => sub { my $fh = shift; while (<$fh>) {
-		if (/^\s*alias\s+(\S+)\s+(.*)$/) {
+		if (/^\s*alias\s+(?:-group\s+\S+\s+)?(\S+)\s+(.*)$/) {
 			my ($alias, $addr) = ($1, $2);
 			$addr =~ s/#.*$//; # mutt allows # comments
 			 # commas delimit multiple addresses

-- 
1.6.5.rc2.1.gec34
Jeff King· Sep 30, 2009, 11:28 UTC · re: Felipe Contreras · lore

Re: [PATCH] send-email: fix mutt regex for grouped aliases

On Wed, Sep 30, 2009 at 03:08:43AM +0300, Felipe Contreras wrote:
> For example:
> alias -group friends foo Foo Bar <foo@bar.com>
Hmm. If I am reading the mutt docs correctly, is it also legal to have:
  alias -group group1 -group group2 foo Foo Bar <foo@bar.com>
?
Which would need just:
> -		if (/^\s*alias\s+(\S+)\s+(.*)$/) {
> +		if (/^\s*alias\s+(?:-group\s+\S+\s+)?(\S+)\s+(.*)$/) {
   (?:-group\s+\S+\s+)*
I think.
-Peff
Felipe Contreras· Sep 30, 2009, 14:49 UTC · re: Jeff King · lore

[PATCH v2] send-email: fix mutt regex for grouped aliases

For example: alias -group friends foo Foo Bar <foo@bar.com>

Comments by Jeff King.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-send-email.perl +1 −1
diff --git a/git-send-email.perl b/git-send-email.perl
index 0700d80..93b7ed2 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -401,7 +401,7 @@ my %aliases;
 my %parse_alias = (
 	# multiline formats can be supported in the future
 	mutt => sub { my $fh = shift; while (<$fh>) {
-		if (/^\s*alias\s+(\S+)\s+(.*)$/) {
+		if (/^\s*alias\s+(?:-group\s+\S+\s+)*(\S+)\s+(.*)$/) {
 			my ($alias, $addr) = ($1, $2);
 			$addr =~ s/#.*$//; # mutt allows # comments
 			 # commas delimit multiple addresses

-- 
1.6.5.rc2.1.g9071
Eric Wong· Sep 30, 2009, 20:55 UTC · re: Felipe Contreras · lore

Re: [PATCH v2] send-email: fix mutt regex for grouped aliases

Felipe Contreras <felipe.contreras@gmail.com> wrote:
Show 6 quoted lines
> For example:
> alias -group friends foo Foo Bar <foo@bar.com>
> 
> Comments by Jeff King.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Interesting, I didn't know about this feature in mutt before.
Acked(-and-tested)-by: Eric Wong <normalperson@yhbt.net>
Show 18 quoted lines
> ---
>  git-send-email.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 0700d80..93b7ed2 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -401,7 +401,7 @@ my %aliases;
>  my %parse_alias = (
>  	# multiline formats can be supported in the future
>  	mutt => sub { my $fh = shift; while (<$fh>) {
> -		if (/^\s*alias\s+(\S+)\s+(.*)$/) {
> +		if (/^\s*alias\s+(?:-group\s+\S+\s+)*(\S+)\s+(.*)$/) {
>  			my ($alias, $addr) = ($1, $2);
>  			$addr =~ s/#.*$//; # mutt allows # comments
>  			 # commas delimit multiple addresses
> --
Jeff King· Oct 1, 2009, 00:22 UTC · re: Eric Wong · lore

Re: [PATCH v2] send-email: fix mutt regex for grouped aliases

On Wed, Sep 30, 2009 at 01:55:01PM -0700, Eric Wong wrote:
Show 11 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > For example:
> > alias -group friends foo Foo Bar <foo@bar.com>
> > 
> > Comments by Jeff King.
> > 
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> 
> Interesting, I didn't know about this feature in mutt before.
> 
> Acked(-and-tested)-by: Eric Wong <normalperson@yhbt.net>

Nor did I, which is why I was reading the docs. :) The v2 patch looks good to me, as well.

-Peff
Felipe Contreras· Sep 30, 2009, 14:50 UTC · re: Jeff King · lore

Re: [PATCH] send-email: fix mutt regex for grouped aliases

On Wed, Sep 30, 2009 at 2:28 PM, Jeff King <peff@peff.net> wrote:
Show 19 quoted lines
> On Wed, Sep 30, 2009 at 03:08:43AM +0300, Felipe Contreras wrote:
>
>> For example:
>> alias -group friends foo Foo Bar <foo@bar.com>
>
> Hmm. If I am reading the mutt docs correctly, is it also legal to have:
>
>  alias -group group1 -group group2 foo Foo Bar <foo@bar.com>
>
> ?
>
> Which would need just:
>
>> -             if (/^\s*alias\s+(\S+)\s+(.*)$/) {
>> +             if (/^\s*alias\s+(?:-group\s+\S+\s+)?(\S+)\s+(.*)$/) {
>
>   (?:-group\s+\S+\s+)*
>
> I think.
Yeap, that is correct. Resent.
-- 
Felipe Contreras

← back to recent threads