# [PATCH] send-email: fix mutt regex for grouped aliases 6 messages from 2009-09-30 to 2009-10-01. Participants: Felipe Contreras, Jeff King, Eric Wong. Thread: https://gitlist.dev/t/21094 ## Felipe Contreras, 2009-09-30 00:08 Subject: [PATCH] send-email: fix mutt regex for grouped aliases Message-ID: <1254269323-16600-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1254269323-16600-1-git-send-email-felipe.contreras%40gmail.com ``` For example: alias -group friends foo Foo Bar Signed-off-by: Felipe Contreras --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 0700d80..ec43a5e 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -401,7 +401,7 @@ my %aliases; my %parse_alias = ( # multiline formats can be supported in the future mutt => sub { my $fh = shift; while (<$fh>) { - if (/^\s*alias\s+(\S+)\s+(.*)$/) { + if (/^\s*alias\s+(?:-group\s+\S+\s+)?(\S+)\s+(.*)$/) { my ($alias, $addr) = ($1, $2); $addr =~ s/#.*$//; # mutt allows # comments # commas delimit multiple addresses -- 1.6.5.rc2.1.gec34 ``` ## Jeff King, 2009-09-30 11:28 Subject: Re: [PATCH] send-email: fix mutt regex for grouped aliases Message-ID: <20090930112833.GA4984@sigio.peff.net> URL: https://gitlist.dev/e/20090930112833.GA4984%40sigio.peff.net In-Reply-To: <1254269323-16600-1-git-send-email-felipe.contreras@gmail.com> ``` On Wed, Sep 30, 2009 at 03:08:43AM +0300, Felipe Contreras wrote: > For example: > alias -group friends foo Foo Bar Hmm. If I am reading the mutt docs correctly, is it also legal to have: alias -group group1 -group group2 foo Foo Bar ? Which would need just: > - if (/^\s*alias\s+(\S+)\s+(.*)$/) { > + if (/^\s*alias\s+(?:-group\s+\S+\s+)?(\S+)\s+(.*)$/) { (?:-group\s+\S+\s+)* I think. -Peff ``` ## Felipe Contreras, 2009-09-30 14:49 Subject: [PATCH v2] send-email: fix mutt regex for grouped aliases Message-ID: <1254322176-4561-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1254322176-4561-1-git-send-email-felipe.contreras%40gmail.com In-Reply-To: <20090930112833.GA4984@sigio.peff.net> ``` For example: alias -group friends foo Foo Bar Comments by Jeff King. Signed-off-by: Felipe Contreras --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 0700d80..93b7ed2 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -401,7 +401,7 @@ my %aliases; my %parse_alias = ( # multiline formats can be supported in the future mutt => sub { my $fh = shift; while (<$fh>) { - if (/^\s*alias\s+(\S+)\s+(.*)$/) { + if (/^\s*alias\s+(?:-group\s+\S+\s+)*(\S+)\s+(.*)$/) { my ($alias, $addr) = ($1, $2); $addr =~ s/#.*$//; # mutt allows # comments # commas delimit multiple addresses -- 1.6.5.rc2.1.g9071 ``` ## Felipe Contreras, 2009-09-30 14:50 Subject: Re: [PATCH] send-email: fix mutt regex for grouped aliases Message-ID: <94a0d4530909300750y4ea5225by3acb72010c6545fb@mail.gmail.com> URL: https://gitlist.dev/e/94a0d4530909300750y4ea5225by3acb72010c6545fb%40mail.gmail.com In-Reply-To: <20090930112833.GA4984@sigio.peff.net> ``` On Wed, Sep 30, 2009 at 2:28 PM, Jeff King wrote: > On Wed, Sep 30, 2009 at 03:08:43AM +0300, Felipe Contreras wrote: > >> For example: >> alias -group friends foo Foo Bar > > Hmm. If I am reading the mutt docs correctly, is it also legal to have: > >  alias -group group1 -group group2 foo Foo Bar > > ? > > Which would need just: > >> -             if (/^\s*alias\s+(\S+)\s+(.*)$/) { >> +             if (/^\s*alias\s+(?:-group\s+\S+\s+)?(\S+)\s+(.*)$/) { > >   (?:-group\s+\S+\s+)* > > I think. Yeap, that is correct. Resent. -- Felipe Contreras ``` ## Eric Wong, 2009-09-30 20:55 Subject: Re: [PATCH v2] send-email: fix mutt regex for grouped aliases Message-ID: <20090930205501.GA30910@dcvr.yhbt.net> URL: https://gitlist.dev/e/20090930205501.GA30910%40dcvr.yhbt.net In-Reply-To: <1254322176-4561-1-git-send-email-felipe.contreras@gmail.com> ``` Felipe Contreras wrote: > For example: > alias -group friends foo Foo Bar > > Comments by Jeff King. > > Signed-off-by: Felipe Contreras Interesting, I didn't know about this feature in mutt before. Acked(-and-tested)-by: Eric Wong > --- > git-send-email.perl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/git-send-email.perl b/git-send-email.perl > index 0700d80..93b7ed2 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -401,7 +401,7 @@ my %aliases; > my %parse_alias = ( > # multiline formats can be supported in the future > mutt => sub { my $fh = shift; while (<$fh>) { > - if (/^\s*alias\s+(\S+)\s+(.*)$/) { > + if (/^\s*alias\s+(?:-group\s+\S+\s+)*(\S+)\s+(.*)$/) { > my ($alias, $addr) = ($1, $2); > $addr =~ s/#.*$//; # mutt allows # comments > # commas delimit multiple addresses > -- ``` ## Jeff King, 2009-10-01 00:22 Subject: Re: [PATCH v2] send-email: fix mutt regex for grouped aliases Message-ID: <20091001002259.GB27967@sigill.intra.peff.net> URL: https://gitlist.dev/e/20091001002259.GB27967%40sigill.intra.peff.net In-Reply-To: <20090930205501.GA30910@dcvr.yhbt.net> ``` On Wed, Sep 30, 2009 at 01:55:01PM -0700, Eric Wong wrote: > Felipe Contreras wrote: > > For example: > > alias -group friends foo Foo Bar > > > > Comments by Jeff King. > > > > Signed-off-by: Felipe Contreras > > Interesting, I didn't know about this feature in mutt before. > > Acked(-and-tested)-by: Eric Wong Nor did I, which is why I was reading the docs. :) The v2 patch looks good to me, as well. -Peff ```