{"thread":{"id":"21094","subject":"[PATCH] send-email: fix mutt regex for grouped aliases","startedAt":"2009-09-30T00:08:43Z","lastAt":"2009-10-01T00:22:59Z","messageCount":6,"participants":["Felipe Contreras","Jeff King","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"124017","messageId":"1254269323-16600-1-git-send-email-felipe.contreras@gmail.com","threadId":"21094","inReplyTo":null,"subject":"[PATCH] send-email: fix mutt regex for grouped aliases","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-09-30T00:08:43Z","receivedAt":"2009-09-30T00:08:43Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"For example:\nalias -group friends foo Foo Bar <foo@bar.com>\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n git-send-email.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 0700d80..ec43a5e 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -401,7 +401,7 @@ my %aliases;\n my %parse_alias = (\n \t# multiline formats can be supported in the future\n \tmutt => sub { my $fh = shift; while (<$fh>) {\n-\t\tif (/^\\s*alias\\s+(\\S+)\\s+(.*)$/) {\n+\t\tif (/^\\s*alias\\s+(?:-group\\s+\\S+\\s+)?(\\S+)\\s+(.*)$/) {\n \t\t\tmy ($alias, $addr) = ($1, $2);\n \t\t\t$addr =~ s/#.*$//; # mutt allows # comments\n \t\t\t # commas delimit multiple addresses\n-- \n1.6.5.rc2.1.gec34\n"},{"id":"124029","messageId":"20090930112833.GA4984@sigio.peff.net","threadId":"21094","inReplyTo":"1254269323-16600-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] send-email: fix mutt regex for grouped aliases","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-09-30T11:28:34Z","receivedAt":"2009-09-30T11:28:34Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Sep 30, 2009 at 03:08:43AM +0300, Felipe Contreras wrote:\n\n> For example:\n> alias -group friends foo Foo Bar <foo@bar.com>\n\nHmm. If I am reading the mutt docs correctly, is it also legal to have:\n\n  alias -group group1 -group group2 foo Foo Bar <foo@bar.com>\n\n?\n\nWhich would need just:\n\n> -\t\tif (/^\\s*alias\\s+(\\S+)\\s+(.*)$/) {\n> +\t\tif (/^\\s*alias\\s+(?:-group\\s+\\S+\\s+)?(\\S+)\\s+(.*)$/) {\n\n   (?:-group\\s+\\S+\\s+)*\n\nI think.\n\n-Peff\n"},{"id":"124033","messageId":"1254322176-4561-1-git-send-email-felipe.contreras@gmail.com","threadId":"21094","inReplyTo":"20090930112833.GA4984@sigio.peff.net","subject":"[PATCH v2] send-email: fix mutt regex for grouped aliases","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-09-30T14:49:36Z","receivedAt":"2009-09-30T14:49:36Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"For example:\nalias -group friends foo Foo Bar <foo@bar.com>\n\nComments by Jeff King.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n git-send-email.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 0700d80..93b7ed2 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -401,7 +401,7 @@ my %aliases;\n my %parse_alias = (\n \t# multiline formats can be supported in the future\n \tmutt => sub { my $fh = shift; while (<$fh>) {\n-\t\tif (/^\\s*alias\\s+(\\S+)\\s+(.*)$/) {\n+\t\tif (/^\\s*alias\\s+(?:-group\\s+\\S+\\s+)*(\\S+)\\s+(.*)$/) {\n \t\t\tmy ($alias, $addr) = ($1, $2);\n \t\t\t$addr =~ s/#.*$//; # mutt allows # comments\n \t\t\t # commas delimit multiple addresses\n-- \n1.6.5.rc2.1.g9071\n"},{"id":"124034","messageId":"94a0d4530909300750y4ea5225by3acb72010c6545fb@mail.gmail.com","threadId":"21094","inReplyTo":"20090930112833.GA4984@sigio.peff.net","subject":"Re: [PATCH] send-email: fix mutt regex for grouped aliases","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2009-09-30T14:50:25Z","receivedAt":"2009-09-30T14:50:25Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Wed, Sep 30, 2009 at 2:28 PM, Jeff King <peff@peff.net> wrote:\n> On Wed, Sep 30, 2009 at 03:08:43AM +0300, Felipe Contreras wrote:\n>\n>> For example:\n>> alias -group friends foo Foo Bar <foo@bar.com>\n>\n> Hmm. If I am reading the mutt docs correctly, is it also legal to have:\n>\n>  alias -group group1 -group group2 foo Foo Bar <foo@bar.com>\n>\n> ?\n>\n> Which would need just:\n>\n>> -             if (/^\\s*alias\\s+(\\S+)\\s+(.*)$/) {\n>> +             if (/^\\s*alias\\s+(?:-group\\s+\\S+\\s+)?(\\S+)\\s+(.*)$/) {\n>\n>   (?:-group\\s+\\S+\\s+)*\n>\n> I think.\n\nYeap, that is correct. Resent.\n\n-- \nFelipe Contreras\n"},{"id":"124046","messageId":"20090930205501.GA30910@dcvr.yhbt.net","threadId":"21094","inReplyTo":"1254322176-4561-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH v2] send-email: fix mutt regex for grouped aliases","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2009-09-30T20:55:01Z","receivedAt":"2009-09-30T20:55:01Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Felipe Contreras <felipe.contreras@gmail.com> wrote:\n> For example:\n> alias -group friends foo Foo Bar <foo@bar.com>\n> \n> Comments by Jeff King.\n> \n> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n\nInteresting, I didn't know about this feature in mutt before.\n\nAcked(-and-tested)-by: Eric Wong <normalperson@yhbt.net>\n\n> ---\n>  git-send-email.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index 0700d80..93b7ed2 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -401,7 +401,7 @@ my %aliases;\n>  my %parse_alias = (\n>  \t# multiline formats can be supported in the future\n>  \tmutt => sub { my $fh = shift; while (<$fh>) {\n> -\t\tif (/^\\s*alias\\s+(\\S+)\\s+(.*)$/) {\n> +\t\tif (/^\\s*alias\\s+(?:-group\\s+\\S+\\s+)*(\\S+)\\s+(.*)$/) {\n>  \t\t\tmy ($alias, $addr) = ($1, $2);\n>  \t\t\t$addr =~ s/#.*$//; # mutt allows # comments\n>  \t\t\t # commas delimit multiple addresses\n> -- \n"},{"id":"124060","messageId":"20091001002259.GB27967@sigill.intra.peff.net","threadId":"21094","inReplyTo":"20090930205501.GA30910@dcvr.yhbt.net","subject":"Re: [PATCH v2] send-email: fix mutt regex for grouped aliases","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-10-01T00:22:59Z","receivedAt":"2009-10-01T00:22:59Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Sep 30, 2009 at 01:55:01PM -0700, Eric Wong wrote:\n\n> Felipe Contreras <felipe.contreras@gmail.com> wrote:\n> > For example:\n> > alias -group friends foo Foo Bar <foo@bar.com>\n> > \n> > Comments by Jeff King.\n> > \n> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n> \n> Interesting, I didn't know about this feature in mutt before.\n> \n> Acked(-and-tested)-by: Eric Wong <normalperson@yhbt.net>\n\nNor did I, which is why I was reading the docs. :) The v2 patch looks\ngood to me, as well.\n\n-Peff\n"}]}