threads / patch / 20756

patchMakefile: remove pointless conditional assignment in SunOS section

Subject: [PATCH] Makefile: remove pointless conditional assignment in SunOS section

## tl;dr

One message between Aug 27, 2009 and Aug 27, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Brandon Casey· Aug 27, 2009, 15:35 UTC · lore
From: Brandon Casey <drafnel@gmail.com>

It is true that NEEDS_RESOLV is needed on SunOS if NO_IPV6 is set since hstrerror() resides in libresolv, but performing this test at its current location is not very useful. It will only have any effect if the user modifies the make variables from the make command line, and will have no effect if a config.mak file is used. A better location for this conditional would have been further down in the Makefile after the config.mak and config.mak.autogen had been parsed. Rather than adding clutter to the Makefile for a conditional that will likely never be triggered, just remove it, and any user on SunOS that manually sets NO_IPV6 can also set NEEDS_RESOLV.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 Makefile |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Show changes to Makefile +0 −3
diff --git a/Makefile b/Makefile
index 66eedef..a9a4d89 100644
--- a/Makefile
+++ b/Makefile
@@ -757,9 +757,6 @@ ifeq ($(uname_S),SunOS)
 		NO_C99_FORMAT = YesPlease
 		NO_STRTOUMAX = YesPlease
 	endif
-	ifdef NO_IPV6
-		NEEDS_RESOLV = YesPlease
-	endif
 	INSTALL = /usr/ucb/install
 	TAR = gtar
 	BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H
-- 
1.6.4

← back to recent threads