{"thread":{"id":"20756","subject":"[PATCH] Makefile: remove pointless conditional assignment in SunOS section","startedAt":"2009-08-27T15:35:46Z","lastAt":"2009-08-27T15:35:46Z","messageCount":1,"participants":["Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"121869","messageId":"dp9hIoAW5cYWA19k8Uz1mjyaMwG81BRJNhvvYiQVR3eKlOcw9qDI2AVF-YGIRUTxe_5qbaek5Qc@cipher.nrlssc.navy.mil","threadId":"20756","inReplyTo":null,"subject":"[PATCH] Makefile: remove pointless conditional assignment in SunOS section","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-08-27T15:35:46Z","receivedAt":"2009-08-27T15:35:46Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\nIt is true that NEEDS_RESOLV is needed on SunOS if NO_IPV6 is set since\nhstrerror() resides in libresolv, but performing this test at its current\nlocation is not very useful.  It will only have any effect if the user\nmodifies the make variables from the make command line, and will have no\neffect if a config.mak file is used.  A better location for this\nconditional would have been further down in the Makefile after the\nconfig.mak and config.mak.autogen had been parsed.  Rather than adding\nclutter to the Makefile for a conditional that will likely never be\ntriggered, just remove it, and any user on SunOS that manually sets NO_IPV6\ncan also set NEEDS_RESOLV.\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n Makefile |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 66eedef..a9a4d89 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -757,9 +757,6 @@ ifeq ($(uname_S),SunOS)\n \t\tNO_C99_FORMAT = YesPlease\n \t\tNO_STRTOUMAX = YesPlease\n \tendif\n-\tifdef NO_IPV6\n-\t\tNEEDS_RESOLV = YesPlease\n-\tendif\n \tINSTALL = /usr/ucb/install\n \tTAR = gtar\n \tBASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H\n-- \n1.6.4\n"}]}