git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: remove pointless conditional assignment in SunOS section

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Aug 27, 2009, 15:35 UTC
Message-ID
<dp9hIoAW5cYWA19k8Uz1mjyaMwG81BRJNhvvYiQVR3eKlOcw9qDI2AVF-YGIRUTxe_5qbaek5Qc@cipher.nrlssc.navy.mil>
From: Brandon Casey <drafnel@gmail.com>

It is true that NEEDS_RESOLV is needed on SunOS if NO_IPV6 is set since hstrerror() resides in libresolv, but performing this test at its current location is not very useful. It will only have any effect if the user modifies the make variables from the make command line, and will have no effect if a config.mak file is used. A better location for this conditional would have been further down in the Makefile after the config.mak and config.mak.autogen had been parsed. Rather than adding clutter to the Makefile for a conditional that will likely never be triggered, just remove it, and any user on SunOS that manually sets NO_IPV6 can also set NEEDS_RESOLV.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 Makefile |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 66eedef..a9a4d89 100644
--- a/Makefile
+++ b/Makefile
@@ -757,9 +757,6 @@ ifeq ($(uname_S),SunOS)
 		NO_C99_FORMAT = YesPlease
 		NO_STRTOUMAX = YesPlease
 	endif
-	ifdef NO_IPV6
-		NEEDS_RESOLV = YesPlease
-	endif
 	INSTALL = /usr/ucb/install
 	TAR = gtar
 	BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H
-- 
1.6.4
Message 1 of 1 in “Makefile: remove pointless conditional assignment in SunOS section”
  1. Makefile: remove pointless conditional assignment in SunOS sectionBrandon Casey, Aug 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.