threads / patch / 20488

patchgit-instaweb: fix mod_perl detection for apache2

Subject: [PATCH] git-instaweb: fix mod_perl detection for apache2

## tl;dr

5 messages between Aug 8, 2009 and Aug 18, 2009. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Mark A Rada· Aug 8, 2009, 22:24 UTC · lore

The script was looking for something that matched the '^our $gitbin' regex, which no longer exists in gitweb.cgi.

Now it looks for 'MOD_PERL', which should be on the line that checks to see if the script is running in a mod_perl environment.

Signed-off-by: Mark Rada <marada@uwaterloo.ca>
---
  git-instaweb.sh |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-instaweb.sh +1 −1

diff --git a/git-instaweb.sh b/git-instaweb.sh
index 32f6496..5f5cac7 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -278,7 +278,7 @@ EOF

  	# check to see if Dennis Stosberg's mod_perl compatibility patch
  	# (<20060621130708.Gcbc6e5c@leonov.stosberg.net>) has been applied
-	if test -f "$module_path/mod_perl.so" && grep '^our $gitbin' \
+	if test -f "$module_path/mod_perl.so" && grep 'MOD_PERL' \
  				"$GIT_DIR/gitweb/gitweb.cgi" >/dev/null
  	then
  		# favor mod_perl if available

-- 
1.6.4

Junio C Hamano· Aug 10, 2009, 01:38 UTC · re: Mark A Rada · lore

Re: [PATCH] git-instaweb: fix mod_perl detection for apache2

Mark A Rada <marada@uwaterloo.ca> writes:

Show 5 quoted lines

> The script was looking for something that matched the '^our $gitbin'
> regex, which no longer exists in gitweb.cgi.
>
> Now it looks for 'MOD_PERL', which should be on the line that checks
> to see if the script is running in a mod_perl environment.

Thanks. That sounds like an ancient bug that in turn perhaps suggests nobody uses instaweb. Will apply to 'maint'..

Jakub Narebski· Aug 10, 2009, 08:55 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-instaweb: fix mod_perl detection for apache2

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> Mark A Rada <marada@uwaterloo.ca> writes:
> 
> > The script was looking for something that matched the '^our $gitbin'
> > regex, which no longer exists in gitweb.cgi.
> >
> > Now it looks for 'MOD_PERL', which should be on the line that checks
> > to see if the script is running in a mod_perl environment.
> 
> Thanks.  That sounds like an ancient bug that in turn perhaps suggests
> nobody uses instaweb.  Will apply to 'maint'..

Hmmm... taking a peek at current "Git User's Survey 2009" results http://www.survs.com/shareResults?survey=2PIMZGU0&rndm=678J66QRA2

11. What Git interfaces, implementations, frontends and tools do you
    use?

    git-instaweb  	3%  	77 / 2712

16. How often do you use the following forms of git commands or extra
    git tools?

    git instaweb 
      never:     1983 - 79%
      rarely:     208 -  8%
      sometimes:   50 -  2% 	
      often:        9 -  0%

    Total respondents  	 2506

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Mark A Rada· Aug 15, 2009, 16:09 UTC · re: Jakub Narebski · lore

Re: [PATCH] git-instaweb: fix mod_perl detection for apache2

Does this means it may be taken off the menu in the not too distant future or deprecated?

-- Mark A Rada (ferrous26) marada@uwaterloo.ca

On 10-Aug-09, at 4:55 AM, Jakub Narebski wrote:

Show 41 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Mark A Rada <marada@uwaterloo.ca> writes:
>>
>>> The script was looking for something that matched the '^our $gitbin'
>>> regex, which no longer exists in gitweb.cgi.
>>>
>>> Now it looks for 'MOD_PERL', which should be on the line that checks
>>> to see if the script is running in a mod_perl environment.
>>
>> Thanks.  That sounds like an ancient bug that in turn perhaps  
>> suggests
>> nobody uses instaweb.  Will apply to 'maint'..
>
> Hmmm... taking a peek at current "Git User's Survey 2009" results
> http://www.survs.com/shareResults?survey=2PIMZGU0&rndm=678J66QRA2
>
> 11. What Git interfaces, implementations, frontends and tools do you
>    use?
>
>    git-instaweb  	3%  	77 / 2712
>
> 16. How often do you use the following forms of git commands or extra
>    git tools?
>
>    git instaweb
>      never:     1983 - 79%
>      rarely:     208 -  8%
>      sometimes:   50 -  2% 	
>      often:        9 -  0% 	
>
>    Total respondents  	 2506
>
> -- 
> Jakub Narebski
> Poland
> ShadeHawk on #git
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jakub Narebski· Aug 18, 2009, 07:45 UTC · re: Mark A Rada · lore

Re: [PATCH] git-instaweb: fix mod_perl detection for apache2

On Wed, 15 Aug 2009, Mark A Rada wrote:

> On 10-Aug-09, at 4:55 AM, Jakub Narebski wrote: 
>> Junio C Hamano <gitster@pobox.com> writes:

Show 25 quoted lines

>>> Thanks.  That sounds like an ancient bug that in turn perhaps  
>>> suggests nobody uses instaweb.  Will apply to 'maint'..
>>
>> Hmmm... taking a peek at current "Git User's Survey 2009" results
>> http://www.survs.com/shareResults?survey=2PIMZGU0&rndm=678J66QRA2
>>
>> 11. What Git interfaces, implementations, frontends and tools do you
>>    use?
>>
>>    git-instaweb  	3%  	77 / 2712
>>
>> 16. How often do you use the following forms of git commands or extra
>>    git tools?
>>
>>    git instaweb
>>      never:     1983 - 79%
>>      rarely:     208 -  8%
>>      sometimes:   50 -  2% 	
>>      often:        9 -  0% 	
>>
>>    Total respondents  	 2506
>>
>
> Does this means it may be taken off the menu in the not too distant  
> future or deprecated?

I don't think so. We keep git-relink, which almost nobody uses, and few know what it does.

I guess that git-instaweb is not advertised enough, but that might change, as Scott Chacon in "Pro Git" mentions / covers git-instaweb.

P.S. I'd like to create GIT::Web, which would use (contrary to gitweb) many CPAN modules (and PAR to help installing it with dependencies), which would use HTTP::Engine (and therefore run as CGI, FastCGI, mod_perl and standalone HTTP::Server::Simple), and be similar in structure to SVN::Web. With it using HTTP::Server::Simple git-instaweb would be needed less... But it is in "Duke Nuke Forever" (or packv4 ;-) future...

-- 
Jakub Narebski
Poland