{"thread":{"id":"20488","subject":"[PATCH] git-instaweb: fix mod_perl detection for apache2","startedAt":"2009-08-08T22:24:02Z","lastAt":"2009-08-18T07:45:37Z","messageCount":5,"participants":["Mark A Rada","Junio C Hamano","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"120017","messageId":"4C22ECF8-8FBE-4E45-A7CF-EA1203B49AA7@mailservices.uwaterloo.ca","threadId":"20488","inReplyTo":null,"subject":"[PATCH] git-instaweb: fix mod_perl detection for apache2","fromName":"Mark A Rada","fromEmail":"marada@uwaterloo.ca","sentAt":"2009-08-08T22:24:02Z","receivedAt":"2009-08-08T22:24:02Z","isPatch":true,"sender":{"key":"marada@uwaterloo.ca","avatar":"https://avatars.githubusercontent.com/u/38430?v=4"},"body":"The script was looking for something that matched the '^our $gitbin'\nregex, which no longer exists in gitweb.cgi.\n\nNow it looks for 'MOD_PERL', which should be on the line that checks\nto see if the script is running in a mod_perl environment.\n\nSigned-off-by: Mark Rada \n---\n git-instaweb.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-instaweb.sh b/git-instaweb.sh\nindex 32f6496..5f5cac7 100755\n--- a/git-instaweb.sh\n+++ b/git-instaweb.sh\n@@ -278,7 +278,7 @@ EOF\n\n \t# check to see if Dennis Stosberg's mod_perl compatibility patch\n \t# (<20060621130708.Gcbc6e5c@leonov.stosberg.net>) has been applied\n-\tif test -f \"$module_path/mod_perl.so\" && grep '^our $gitbin' \\\n+\tif test -f \"$module_path/mod_perl.so\" && grep 'MOD_PERL' \\\n \t\t\t\t\"$GIT_DIR/gitweb/gitweb.cgi\" >/dev/null\n \tthen\n \t\t# favor mod_perl if available\n-- \n1.6.4\n"},{"id":"120103","messageId":"7vprb45ty7.fsf@alter.siamese.dyndns.org","threadId":"20488","inReplyTo":"4C22ECF8-8FBE-4E45-A7CF-EA1203B49AA7@mailservices.uwaterloo.ca","subject":"Re: [PATCH] git-instaweb: fix mod_perl detection for apache2","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-08-10T01:38:40Z","receivedAt":"2009-08-10T01:38:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mark A Rada writes:\n\n> The script was looking for something that matched the '^our $gitbin'\n> regex, which no longer exists in gitweb.cgi.\n>\n> Now it looks for 'MOD_PERL', which should be on the line that checks\n> to see if the script is running in a mod_perl environment.\n\nThanks. That sounds like an ancient bug that in turn perhaps suggests\nnobody uses instaweb. Will apply to 'maint'..\n"},{"id":"120128","messageId":"m3iqgwoxq7.fsf@localhost.localdomain","threadId":"20488","inReplyTo":"7vprb45ty7.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git-instaweb: fix mod_perl detection for apache2","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-08-10T08:55:34Z","receivedAt":"2009-08-10T08:55:34Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano writes:\n\n> Mark A Rada writes:\n> \n> > The script was looking for something that matched the '^our $gitbin'\n> > regex, which no longer exists in gitweb.cgi.\n> >\n> > Now it looks for 'MOD_PERL', which should be on the line that checks\n> > to see if the script is running in a mod_perl environment.\n> \n> Thanks. That sounds like an ancient bug that in turn perhaps suggests\n> nobody uses instaweb. Will apply to 'maint'..\n\nHmmm... taking a peek at current \"Git User's Survey 2009\" results\nhttp://www.survs.com/shareResults?survey=2PIMZGU0&rndm=678J66QRA2\n\n11. What Git interfaces, implementations, frontends and tools do you\n use?\n\n git-instaweb \t3% \t77 / 2712\n\n16. How often do you use the following forms of git commands or extra\n git tools? \n\n git instaweb \n never: 1983 - 79%\n rarely: 208 - 8%\n sometimes: 50 - 2% \t\n often: 9 - 0% \t\n\n Total respondents \t 2506\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"120716","messageId":"3300D840-9BAB-4233-B949-6A5B300CD9A8@mailservices.uwaterloo.ca","threadId":"20488","inReplyTo":"m3iqgwoxq7.fsf@localhost.localdomain","subject":"Re: [PATCH] git-instaweb: fix mod_perl detection for apache2","fromName":"Mark A Rada","fromEmail":"marada@uwaterloo.ca","sentAt":"2009-08-15T16:09:34Z","receivedAt":"2009-08-15T16:09:34Z","isPatch":true,"sender":{"key":"marada@uwaterloo.ca","avatar":"https://avatars.githubusercontent.com/u/38430?v=4"},"body":"Does this means it may be taken off the menu in the not too distant \nfuture or\ndeprecated?\n\n--\nMark A Rada (ferrous26)\nmarada@uwaterloo.ca\n\n\nOn 10-Aug-09, at 4:55 AM, Jakub Narebski wrote:\n\n> Junio C Hamano writes:\n>\n>> Mark A Rada writes:\n>>\n>>> The script was looking for something that matched the '^our $gitbin'\n>>> regex, which no longer exists in gitweb.cgi.\n>>>\n>>> Now it looks for 'MOD_PERL', which should be on the line that checks\n>>> to see if the script is running in a mod_perl environment.\n>>\n>> Thanks. That sounds like an ancient bug that in turn perhaps \n>> suggests\n>> nobody uses instaweb. Will apply to 'maint'..\n>\n> Hmmm... taking a peek at current \"Git User's Survey 2009\" results\n> http://www.survs.com/shareResults?survey=2PIMZGU0&rndm=678J66QRA2\n>\n> 11. What Git interfaces, implementations, frontends and tools do you\n> use?\n>\n> git-instaweb \t3% \t77 / 2712\n>\n> 16. How often do you use the following forms of git commands or extra\n> git tools?\n>\n> git instaweb\n> never: 1983 - 79%\n> rarely: 208 - 8%\n> sometimes: 50 - 2% \t\n> often: 9 - 0% \t\n>\n> Total respondents \t 2506\n>\n> -- \n> Jakub Narebski\n> Poland\n> ShadeHawk on #git\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n"},{"id":"121062","messageId":"200908180945.40412.jnareb@gmail.com","threadId":"20488","inReplyTo":"3300D840-9BAB-4233-B949-6A5B300CD9A8@mailservices.uwaterloo.ca","subject":"Re: [PATCH] git-instaweb: fix mod_perl detection for apache2","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-08-18T07:45:37Z","receivedAt":"2009-08-18T07:45:37Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Wed, 15 Aug 2009, Mark A Rada wrote:\n> On 10-Aug-09, at 4:55 AM, Jakub Narebski wrote: \n>> Junio C Hamano writes:\n\n>>> Thanks. That sounds like an ancient bug that in turn perhaps \n>>> suggests nobody uses instaweb. Will apply to 'maint'..\n>>\n>> Hmmm... taking a peek at current \"Git User's Survey 2009\" results\n>> http://www.survs.com/shareResults?survey=2PIMZGU0&rndm=678J66QRA2\n>>\n>> 11. What Git interfaces, implementations, frontends and tools do you\n>> use?\n>>\n>> git-instaweb \t3% \t77 / 2712\n>>\n>> 16. How often do you use the following forms of git commands or extra\n>> git tools?\n>>\n>> git instaweb\n>> never: 1983 - 79%\n>> rarely: 208 - 8%\n>> sometimes: 50 - 2% \t\n>> often: 9 - 0% \t\n>>\n>> Total respondents \t 2506\n>>\n>\n> Does this means it may be taken off the menu in the not too distant \n> future or deprecated?\n\nI don't think so. We keep git-relink, which almost nobody uses, and\nfew know what it does.\n\nI guess that git-instaweb is not advertised enough, but that might \nchange, as Scott Chacon in \"Pro Git\" mentions / covers git-instaweb.\n\n\nP.S. I'd like to create GIT::Web, which would use (contrary to gitweb)\nmany CPAN modules (and PAR to help installing it with dependencies),\nwhich would use HTTP::Engine (and therefore run as CGI, FastCGI, \nmod_perl and standalone HTTP::Server::Simple), and be similar in \nstructure to SVN::Web. With it using HTTP::Server::Simple git-instaweb \nwould be needed less... But it is in \"Duke Nuke Forever\" (or \npackv4 ;-) future...\n\n-- \nJakub Narebski\nPoland\n"}]}