git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-instaweb: fix mod_perl detection for apache2

From
Mark A Rada <marada@uwaterloo.ca>
Date
Aug 8, 2009, 22:24 UTC
Message-ID
<4C22ECF8-8FBE-4E45-A7CF-EA1203B49AA7@mailservices.uwaterloo.ca>

The script was looking for something that matched the '^our $gitbin' regex, which no longer exists in gitweb.cgi.

Now it looks for 'MOD_PERL', which should be on the line that checks to see if the script is running in a mod_perl environment.

Signed-off-by: Mark Rada <marada@uwaterloo.ca>
---
  git-instaweb.sh |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 32f6496..5f5cac7 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -278,7 +278,7 @@ EOF

  	# check to see if Dennis Stosberg's mod_perl compatibility patch
  	# (<20060621130708.Gcbc6e5c@leonov.stosberg.net>) has been applied
-	if test -f "$module_path/mod_perl.so" && grep '^our $gitbin' \
+	if test -f "$module_path/mod_perl.so" && grep 'MOD_PERL' \
  				"$GIT_DIR/gitweb/gitweb.cgi" >/dev/null
  	then
  		# favor mod_perl if available
-- 
1.6.4
Next: Junio C Hamano
Message 1 of 5 in “git-instaweb: fix mod_perl detection for apache2”
  1. git-instaweb: fix mod_perl detection for apache2Mark A Rada, Aug 8, 2009
  2. Junio C HamanoAug 10, 2009
  3. Jakub NarebskiAug 10, 2009
  4. Mark A RadaAug 15, 2009
  5. Jakub NarebskiAug 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.