threads / patch / 20476

patch, 9 partsadd missing long options to 'git push bash completion'

Subject: [PATCH 5/9] add missing long options to 'git push bash completion'

## tl;dr

2 messages between Aug 8, 2009 and Aug 8, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Emmanuel Trillaud· Aug 8, 2009, 08:56 UTC · lore

according to git-push(1), the following long-options are missing to the bash
completion :
--porcelain
--thin
--no-thin
Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>
---
 contrib/completion/git-completion.bash |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Show changes to contrib/completion/git-completion.bash +3 −1

diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index a4e78d5..98e1185 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1296,8 +1296,10 @@ _git_push ()
 		;;
 	--*)
 		__gitcomp "
-			--all --mirror --tags --dry-run --force --verbose
+			--all --mirror --dry-run --porcelain --tags --force --verbose
 			--receive-pack= --repo=
+			--thin
+			--no-thin
 		"
 		return
 		;;

-- 
1.6.4

Junio C Hamano· Aug 8, 2009, 19:50 UTC · re: Emmanuel Trillaud · lore

Re: [PATCH 5/9] add missing long options to 'git push bash completion'

Emmanuel Trillaud <etrillaud@gmail.com> writes:

Show 5 quoted lines

> according to git-push(1), the following long-options are missing to the bash
> completion :
> --porcelain
> --thin
> --no-thin

Does it even make sense to complete --porcelain in interactive session?

For that matter, I think being able to control --thin/--no-thin outlived their usefulness. Have you ever used them to toggle this aspect of the behaviour per invocation?