{"thread":{"id":"20476","subject":"[PATCH 5/9] add missing long options to 'git push bash completion'","startedAt":"2009-08-08T08:56:27Z","lastAt":"2009-08-08T19:50:31Z","messageCount":2,"participants":["Emmanuel Trillaud","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":9},"messages":[{"id":"119977","messageId":"9f50533b0908080156n3e990a69lc54e8ab4f0422d0a@mail.gmail.com","threadId":"20476","inReplyTo":null,"subject":"[PATCH 5/9] add missing long options to 'git push bash completion'","fromName":"Emmanuel Trillaud","fromEmail":"etrillaud@gmail.com","sentAt":"2009-08-08T08:56:27Z","receivedAt":"2009-08-08T08:56:27Z","isPatch":true,"sender":{"key":"etrillaud@gmail.com","avatar":null},"body":"according to git-push(1), the following long-options are missing to the bash\ncompletion :\n--porcelain\n--thin\n--no-thin\nSigned-off-by: Emmanuel Trillaud <etrillaud@gmail.com>\n---\n contrib/completion/git-completion.bash |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash\nb/contrib/completion/git-completion.bash\nindex a4e78d5..98e1185 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1296,8 +1296,10 @@ _git_push ()\n \t\t;;\n \t--*)\n \t\t__gitcomp \"\n-\t\t\t--all --mirror --tags --dry-run --force --verbose\n+\t\t\t--all --mirror --dry-run --porcelain --tags --force --verbose\n \t\t\t--receive-pack= --repo=\n+\t\t\t--thin\n+\t\t\t--no-thin\n \t\t\"\n \t\treturn\n \t\t;;\n-- \n1.6.4\n"},{"id":"120011","messageId":"7v4osidr08.fsf@alter.siamese.dyndns.org","threadId":"20476","inReplyTo":"9f50533b0908080156n3e990a69lc54e8ab4f0422d0a@mail.gmail.com","subject":"Re: [PATCH 5/9] add missing long options to 'git push bash completion'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-08-08T19:50:31Z","receivedAt":"2009-08-08T19:50:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Emmanuel Trillaud <etrillaud@gmail.com> writes:\n\n> according to git-push(1), the following long-options are missing to the bash\n> completion :\n> --porcelain\n> --thin\n> --no-thin\n\nDoes it even make sense to complete --porcelain in interactive session?\n\nFor that matter, I think being able to control --thin/--no-thin outlived\ntheir usefulness.  Have you ever used them to toggle this aspect of the\nbehaviour per invocation?\n"}]}