# [PATCH 5/9] add missing long options to 'git push bash completion'

2 messages from 2009-08-08 to 2009-08-08. Participants: Emmanuel Trillaud, Junio C Hamano.
Thread: https://gitlist.dev/t/20476

## Emmanuel Trillaud, 2009-08-08 08:56

Subject: [PATCH 5/9] add missing long options to 'git push bash completion'
Message-ID: <9f50533b0908080156n3e990a69lc54e8ab4f0422d0a@mail.gmail.com>
URL: https://gitlist.dev/e/9f50533b0908080156n3e990a69lc54e8ab4f0422d0a%40mail.gmail.com

```
according to git-push(1), the following long-options are missing to the bash
completion :
--porcelain
--thin
--no-thin
Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>
---
 contrib/completion/git-completion.bash |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index a4e78d5..98e1185 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1296,8 +1296,10 @@ _git_push ()
 		;;
 	--*)
 		__gitcomp "
-			--all --mirror --tags --dry-run --force --verbose
+			--all --mirror --dry-run --porcelain --tags --force --verbose
 			--receive-pack= --repo=
+			--thin
+			--no-thin
 		"
 		return
 		;;
-- 
1.6.4

```

## Junio C Hamano, 2009-08-08 19:50

Subject: Re: [PATCH 5/9] add missing long options to 'git push bash completion'
Message-ID: <7v4osidr08.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v4osidr08.fsf%40alter.siamese.dyndns.org
In-Reply-To: <9f50533b0908080156n3e990a69lc54e8ab4f0422d0a@mail.gmail.com>

```
Emmanuel Trillaud <etrillaud@gmail.com> writes:

> according to git-push(1), the following long-options are missing to the bash
> completion :
> --porcelain
> --thin
> --no-thin

Does it even make sense to complete --porcelain in interactive session?

For that matter, I think being able to control --thin/--no-thin outlived
their usefulness.  Have you ever used them to toggle this aspect of the
behaviour per invocation?

```