threads / patch / 20374

patchsend-email: remove debug trace

Subject: [PATCH] send-email: remove debug trace

## tl;dr

3 messages between Aug 4, 2009 and Aug 4, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Erik Faye-Lund· Aug 4, 2009, 21:57 UTC · lore

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---

This isn't really a big deal, the print just annoyed me slightly.

 git-send-email.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Show changes to git-send-email.perl +0 −1

diff --git a/git-send-email.perl b/git-send-email.perl
index d508f83..0700d80 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -450,7 +450,6 @@ sub check_file_rev_conflict($) {
 	try {
 		$repo->command('rev-parse', '--verify', '--quiet', $f);
 		if (defined($format_patch)) {
-			print "foo\n";
 			return $format_patch;
 		}
 		die(<<EOF);

-- 
1.6.4

Junio C Hamano· Aug 4, 2009, 22:20 UTC · re: Erik Faye-Lund · lore

Re: [PATCH] send-email: remove debug trace

Erik Faye-Lund <kusmabite@googlemail.com> writes:

> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> This isn't really a big deal, the print just annoyed me slightly.

Nobody noticed for the past 9 months?  Interesting.

Thanks.

Show 18 quoted lines

>
>  git-send-email.perl |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index d508f83..0700d80 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -450,7 +450,6 @@ sub check_file_rev_conflict($) {
>  	try {
>  		$repo->command('rev-parse', '--verify', '--quiet', $f);
>  		if (defined($format_patch)) {
> -			print "foo\n";
>  			return $format_patch;
>  		}
>  		die(<<EOF);
> -- 
> 1.6.4

Erik Faye-Lund· Aug 4, 2009, 23:22 UTC · re: Junio C Hamano · lore

Re: [PATCH] send-email: remove debug trace

On Wed, Aug 5, 2009 at 12:20 AM, Junio C Hamano<gitster@pobox.com> wrote:

> Nobody noticed for the past 9 months?  Interesting.

My guess is that not that many people are using --[no-]format-patch, since it's only really useful if you have file names that collide with git references. Who calls their files things like "HEAD~5..HEAD~2"? :)

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656