# [PATCH] send-email: remove debug trace 3 messages from 2009-08-04 to 2009-08-04. Participants: Erik Faye-Lund, Junio C Hamano. Thread: https://gitlist.dev/t/20374 ## Erik Faye-Lund, 2009-08-04 21:57 Subject: [PATCH] send-email: remove debug trace Message-ID: <1249423054-3416-1-git-send-email-kusmabite@gmail.com> URL: https://gitlist.dev/e/1249423054-3416-1-git-send-email-kusmabite%40gmail.com ``` Signed-off-by: Erik Faye-Lund --- This isn't really a big deal, the print just annoyed me slightly. git-send-email.perl | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index d508f83..0700d80 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -450,7 +450,6 @@ sub check_file_rev_conflict($) { try { $repo->command('rev-parse', '--verify', '--quiet', $f); if (defined($format_patch)) { - print "foo\n"; return $format_patch; } die(< URL: https://gitlist.dev/e/7vbpmvfcgz.fsf%40alter.siamese.dyndns.org In-Reply-To: <1249423054-3416-1-git-send-email-kusmabite@gmail.com> ``` Erik Faye-Lund writes: > Signed-off-by: Erik Faye-Lund > --- > > This isn't really a big deal, the print just annoyed me slightly. Nobody noticed for the past 9 months? Interesting. Thanks. > > git-send-email.perl | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/git-send-email.perl b/git-send-email.perl > index d508f83..0700d80 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -450,7 +450,6 @@ sub check_file_rev_conflict($) { > try { > $repo->command('rev-parse', '--verify', '--quiet', $f); > if (defined($format_patch)) { > - print "foo\n"; > return $format_patch; > } > die(< -- > 1.6.4 ``` ## Erik Faye-Lund, 2009-08-04 23:22 Subject: Re: [PATCH] send-email: remove debug trace Message-ID: <40aa078e0908041622p7cf2097cy4e8a673313a9a2a1@mail.gmail.com> URL: https://gitlist.dev/e/40aa078e0908041622p7cf2097cy4e8a673313a9a2a1%40mail.gmail.com In-Reply-To: <7vbpmvfcgz.fsf@alter.siamese.dyndns.org> ``` On Wed, Aug 5, 2009 at 12:20 AM, Junio C Hamano wrote: > Nobody noticed for the past 9 months?  Interesting. My guess is that not that many people are using --[no-]format-patch, since it's only really useful if you have file names that collide with git references. Who calls their files things like "HEAD~5..HEAD~2"? :) -- Erik "kusma" Faye-Lund kusmabite@gmail.com (+47) 986 59 656 ```