{"thread":{"id":"20374","subject":"[PATCH] send-email: remove debug trace","startedAt":"2009-08-04T21:57:34Z","lastAt":"2009-08-04T23:22:45Z","messageCount":3,"participants":["Erik Faye-Lund","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"119530","messageId":"1249423054-3416-1-git-send-email-kusmabite@gmail.com","threadId":"20374","inReplyTo":null,"subject":"[PATCH] send-email: remove debug trace","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-08-04T21:57:34Z","receivedAt":"2009-08-04T21:57:34Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>\n---\n\nThis isn't really a big deal, the print just annoyed me slightly.\n\n git-send-email.perl |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex d508f83..0700d80 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -450,7 +450,6 @@ sub check_file_rev_conflict($) {\n \ttry {\n \t\t$repo->command('rev-parse', '--verify', '--quiet', $f);\n \t\tif (defined($format_patch)) {\n-\t\t\tprint \"foo\\n\";\n \t\t\treturn $format_patch;\n \t\t}\n \t\tdie(<<EOF);\n-- \n1.6.4\n"},{"id":"119534","messageId":"7vbpmvfcgz.fsf@alter.siamese.dyndns.org","threadId":"20374","inReplyTo":"1249423054-3416-1-git-send-email-kusmabite@gmail.com","subject":"Re: [PATCH] send-email: remove debug trace","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-08-04T22:20:12Z","receivedAt":"2009-08-04T22:20:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Erik Faye-Lund <kusmabite@googlemail.com> writes:\n\n> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>\n> ---\n>\n> This isn't really a big deal, the print just annoyed me slightly.\n\nNobody noticed for the past 9 months?  Interesting.\n\nThanks.\n\n>\n>  git-send-email.perl |    1 -\n>  1 files changed, 0 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index d508f83..0700d80 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -450,7 +450,6 @@ sub check_file_rev_conflict($) {\n>  \ttry {\n>  \t\t$repo->command('rev-parse', '--verify', '--quiet', $f);\n>  \t\tif (defined($format_patch)) {\n> -\t\t\tprint \"foo\\n\";\n>  \t\t\treturn $format_patch;\n>  \t\t}\n>  \t\tdie(<<EOF);\n> -- \n> 1.6.4\n"},{"id":"119541","messageId":"40aa078e0908041622p7cf2097cy4e8a673313a9a2a1@mail.gmail.com","threadId":"20374","inReplyTo":"7vbpmvfcgz.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] send-email: remove debug trace","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@googlemail.com","sentAt":"2009-08-04T23:22:45Z","receivedAt":"2009-08-04T23:22:45Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Wed, Aug 5, 2009 at 12:20 AM, Junio C Hamano<gitster@pobox.com> wrote:\n> Nobody noticed for the past 9 months?  Interesting.\n\nMy guess is that not that many people are using --[no-]format-patch,\nsince it's only really useful if you have file names that collide with\ngit references. Who calls their files things like \"HEAD~5..HEAD~2\"? :)\n\n-- \nErik \"kusma\" Faye-Lund\nkusmabite@gmail.com\n(+47) 986 59 656\n"}]}