configure: is NEEDS_SSL_WITH_CRYPTO test correct?

AC_CHECK_LIB([crypto], [SHA1_Init],
   [NEEDS_SSL_WITH_CRYPTO=],
   [AC_CHECK_LIB([ssl], [SHA1_Init],
      [NEEDS_SSL_WITH_CRYPTO=YesPlease NEEDS_SSL_WITH_CRYPTO=],
      [NO_OPENSSL=YesPlease])])

should it rather be:

AC_CHECK_LIB([crypto], [SHA1_Init],
   [NEEDS_SSL_WITH_CRYPTO=],
   [AC_CHECK_LIB([ssl], [SHA1_Init],
      [NEEDS_SSL_WITH_CRYPTO=YesPlease],
      [NEEDS_SSL_WITH_CRYPTO= NO_OPENSSL=YesPlease])])

Notice the pairing of "action" parameters to the inner AC_CHECK_LIB(). The first one seems to set, and then unset NEEDS_SSL_WITH_CRYPTO. Not sure what is going on there. Was the unsetting of NEEDS_SSL_WITH_CRYPTO supposed to go into the action-if-not-found section?

-brandon

Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> writes:

Yuck.

We expect to find SHA1_Init in -lcrypto, and if we find it there we do not do anything funky. If we do not find it in -lcrypto, we try -lssl and if we find it then we know we do need -lssl when saying -lcrypto. Otherwise we do not seem to have OpenSSL.

That is how I read your version, and it makes perfect sense to me.

Thanks.

From: Brandon Casey <drafnel@gmail.com>

The empty assignment NEEDS_SSL_WITH_CRYPTO= was mistakenly paired with the assignment NEEDS_SSL_WITH_CRYPTO=YesPlease in the "action-if-found" parameter of the AC_CHECK_LIB macro. The empty assignment was intended for the "action-if-not-found" section, since in that case, the necessary sha1 hash function was not found and the internal sha1 implementation will be used instead.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---

If you haven't already fixed this, here's a patch to do so.

-brandon

 configure.ac |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

From: Brandon Casey <drafnel@gmail.com>

The empty assignment NEEDS_SSL_WITH_CRYPTO= was mistakenly paired with the assignment NEEDS_SSL_WITH_CRYPTO=YesPlease in the "action-if-found" parameter of the AC_CHECK_LIB macro. The empty assignment was intended for the "action-if-not-found" section, since in that case, the necessary sha1 hash function was not found and the internal sha1 implementation will be used instead.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---

If you haven't already fixed this, here's a patch to do so.

-brandon

 configure.ac |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)