git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] configure.ac: properly unset NEEDS_SSL_WITH_CRYPTO when sha1 func is missing

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jul 22, 2009, 22:20 UTC
Message-ID
<fXvtyZqTXuItyftUWemaP4LOisK2cjVlw5rvtjWxiqExiulCpErwC7p2lHUbi-9P3e0-yUSP3O0@cipher.nrlssc.navy.mil>
In-Reply-To
<7vk521g9c6.fsf@alter.siamese.dyndns.org>
From: Brandon Casey <drafnel@gmail.com>

The empty assignment NEEDS_SSL_WITH_CRYPTO= was mistakenly paired with the assignment NEEDS_SSL_WITH_CRYPTO=YesPlease in the "action-if-found" parameter of the AC_CHECK_LIB macro. The empty assignment was intended for the "action-if-not-found" section, since in that case, the necessary sha1 hash function was not found and the internal sha1 implementation will be used instead.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
If you haven't already fixed this, here's a patch to do so.
-brandon
 configure.ac |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index ba44cf2..3f1922d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -342,9 +342,8 @@ GIT_STASH_FLAGS($OPENSSLDIR)
 AC_CHECK_LIB([crypto], [SHA1_Init],
 [NEEDS_SSL_WITH_CRYPTO=],
 [AC_CHECK_LIB([ssl], [SHA1_Init],
- [NEEDS_SSL_WITH_CRYPTO=YesPlease
-  NEEDS_SSL_WITH_CRYPTO=],
- [NO_OPENSSL=YesPlease])])
+ [NEEDS_SSL_WITH_CRYPTO=YesPlease],
+ [NEEDS_SSL_WITH_CRYPTO= NO_OPENSSL=YesPlease])])
 
 GIT_UNSTASH_FLAGS($OPENSSLDIR)
 
-- 
1.6.3.1.24.g152f4
Previous: Brandon Casey
Message 4 of 4 in “configure: is NEEDS_SSL_WITH_CRYPTO test correct?”
  1. Brandon CaseyJul 21, 2009
  2. Junio C HamanoJul 21, 2009
  3. configure.ac: properly unset NEEDS_SSL_WITH_CRYPTO when sha1 func is missingBrandon Casey, Jul 22, 2009
  4. configure.ac: properly unset NEEDS_SSL_WITH_CRYPTO when sha1 func is missingBrandon Casey, Jul 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.