{"thread":{"id":"20177","subject":"configure: is NEEDS_SSL_WITH_CRYPTO test correct?","startedAt":"2009-07-21T15:29:32Z","lastAt":"2009-07-22T22:20:53Z","messageCount":4,"participants":["Brandon Casey","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"118377","messageId":"TV3HaUyeB7DH8euAZskzz1ryGof9Nj4sfUP9TBnI8xKT3cuwWrFLpQ@cipher.nrlssc.navy.mil","threadId":"20177","inReplyTo":null,"subject":"configure: is NEEDS_SSL_WITH_CRYPTO test correct?","fromName":"Brandon Casey","fromEmail":"brandon.casey.ctr@nrlssc.navy.mil","sentAt":"2009-07-21T15:29:32Z","receivedAt":"2009-07-21T15:29:32Z","isPatch":false,"sender":{"key":"brandon.casey.ctr@nrlssc.navy.mil","avatar":null},"body":"\n>From configure.ac, but re-nested:\n\nAC_CHECK_LIB([crypto], [SHA1_Init],\n [NEEDS_SSL_WITH_CRYPTO=],\n [AC_CHECK_LIB([ssl], [SHA1_Init],\n [NEEDS_SSL_WITH_CRYPTO=YesPlease NEEDS_SSL_WITH_CRYPTO=],\n [NO_OPENSSL=YesPlease])])\n\nshould it rather be:\n\nAC_CHECK_LIB([crypto], [SHA1_Init],\n [NEEDS_SSL_WITH_CRYPTO=],\n [AC_CHECK_LIB([ssl], [SHA1_Init],\n [NEEDS_SSL_WITH_CRYPTO=YesPlease],\n [NEEDS_SSL_WITH_CRYPTO= NO_OPENSSL=YesPlease])])\n\nNotice the pairing of \"action\" parameters to the inner AC_CHECK_LIB().\nThe first one seems to set, and then unset NEEDS_SSL_WITH_CRYPTO. Not\nsure what is going on there. Was the unsetting of NEEDS_SSL_WITH_CRYPTO\nsupposed to go into the action-if-not-found section?\n\n-brandon\n"},{"id":"118393","messageId":"7vk521g9c6.fsf@alter.siamese.dyndns.org","threadId":"20177","inReplyTo":"TV3HaUyeB7DH8euAZskzz1ryGof9Nj4sfUP9TBnI8xKT3cuwWrFLpQ@cipher.nrlssc.navy.mil","subject":"Re: configure: is NEEDS_SSL_WITH_CRYPTO test correct?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-07-21T18:49:29Z","receivedAt":"2009-07-21T18:49:29Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brandon Casey writes:\n\n> From configure.ac, but re-nested:\n>\n> AC_CHECK_LIB([crypto], [SHA1_Init],\n> [NEEDS_SSL_WITH_CRYPTO=],\n> [AC_CHECK_LIB([ssl], [SHA1_Init],\n> [NEEDS_SSL_WITH_CRYPTO=YesPlease NEEDS_SSL_WITH_CRYPTO=],\n> [NO_OPENSSL=YesPlease])])\n\nYuck.\n\n> should it rather be:\n>\n> AC_CHECK_LIB([crypto], [SHA1_Init],\n> [NEEDS_SSL_WITH_CRYPTO=],\n> [AC_CHECK_LIB([ssl], [SHA1_Init],\n> [NEEDS_SSL_WITH_CRYPTO=YesPlease],\n> [NEEDS_SSL_WITH_CRYPTO= NO_OPENSSL=YesPlease])])\n\nWe expect to find SHA1_Init in -lcrypto, and if we find it there we do not\ndo anything funky. If we do not find it in -lcrypto, we try -lssl and if\nwe find it then we know we do need -lssl when saying -lcrypto. Otherwise\nwe do not seem to have OpenSSL.\n\nThat is how I read your version, and it makes perfect sense to me.\n\n> Notice the pairing of \"action\" parameters to the inner AC_CHECK_LIB().\n> The first one seems to set, and then unset NEEDS_SSL_WITH_CRYPTO. Not\n> sure what is going on there. Was the unsetting of NEEDS_SSL_WITH_CRYPTO\n> supposed to go into the action-if-not-found section?\n\nThanks.\n"},{"id":"118516","messageId":"fXvtyZqTXuIladfxuwXdIfda7yrkxDlOZjc2eF5mi-ghnq1WUYZyXUmYBktl6Gq67H5ttK6JmaQ@cipher.nrlssc.navy.mil","threadId":"20177","inReplyTo":"7vk521g9c6.fsf@alter.siamese.dyndns.org","subject":"[PATCH] configure.ac: properly unset NEEDS_SSL_WITH_CRYPTO when sha1 func is missing","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-07-22T22:20:03Z","receivedAt":"2009-07-22T22:20:03Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey \n\nThe empty assignment NEEDS_SSL_WITH_CRYPTO= was mistakenly paired with the\nassignment NEEDS_SSL_WITH_CRYPTO=YesPlease in the \"action-if-found\"\nparameter of the AC_CHECK_LIB macro. The empty assignment was intended for\nthe \"action-if-not-found\" section, since in that case, the necessary sha1\nhash function was not found and the internal sha1 implementation will be\nused instead.\n\nSigned-off-by: Brandon Casey \n---\n\n\nIf you haven't already fixed this, here's a patch to do so.\n\n-brandon\n\n\n configure.ac | 5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex ba44cf2..3f1922d 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -342,9 +342,8 @@ GIT_STASH_FLAGS($OPENSSLDIR)\n AC_CHECK_LIB([crypto], [SHA1_Init],\n [NEEDS_SSL_WITH_CRYPTO=],\n [AC_CHECK_LIB([ssl], [SHA1_Init],\n- [NEEDS_SSL_WITH_CRYPTO=YesPlease\n- NEEDS_SSL_WITH_CRYPTO=],\n- [NO_OPENSSL=YesPlease])])\n+ [NEEDS_SSL_WITH_CRYPTO=YesPlease],\n+ [NEEDS_SSL_WITH_CRYPTO= NO_OPENSSL=YesPlease])])\n \n GIT_UNSTASH_FLAGS($OPENSSLDIR)\n \n-- \n1.6.3.1.24.g152f4\n"},{"id":"118513","messageId":"fXvtyZqTXuItyftUWemaP4LOisK2cjVlw5rvtjWxiqExiulCpErwC7p2lHUbi-9P3e0-yUSP3O0@cipher.nrlssc.navy.mil","threadId":"20177","inReplyTo":"7vk521g9c6.fsf@alter.siamese.dyndns.org","subject":"[PATCH] configure.ac: properly unset NEEDS_SSL_WITH_CRYPTO when sha1 func is missing","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2009-07-22T22:20:53Z","receivedAt":"2009-07-22T22:20:53Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey \n\nThe empty assignment NEEDS_SSL_WITH_CRYPTO= was mistakenly paired with the\nassignment NEEDS_SSL_WITH_CRYPTO=YesPlease in the \"action-if-found\"\nparameter of the AC_CHECK_LIB macro. The empty assignment was intended for\nthe \"action-if-not-found\" section, since in that case, the necessary sha1\nhash function was not found and the internal sha1 implementation will be\nused instead.\n\nSigned-off-by: Brandon Casey \n---\n\n\nIf you haven't already fixed this, here's a patch to do so.\n\n-brandon\n\n\n configure.ac | 5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex ba44cf2..3f1922d 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -342,9 +342,8 @@ GIT_STASH_FLAGS($OPENSSLDIR)\n AC_CHECK_LIB([crypto], [SHA1_Init],\n [NEEDS_SSL_WITH_CRYPTO=],\n [AC_CHECK_LIB([ssl], [SHA1_Init],\n- [NEEDS_SSL_WITH_CRYPTO=YesPlease\n- NEEDS_SSL_WITH_CRYPTO=],\n- [NO_OPENSSL=YesPlease])])\n+ [NEEDS_SSL_WITH_CRYPTO=YesPlease],\n+ [NEEDS_SSL_WITH_CRYPTO= NO_OPENSSL=YesPlease])])\n \n GIT_UNSTASH_FLAGS($OPENSSLDIR)\n \n-- \n1.6.3.1.24.g152f4\n"}]}