threads / patch / 20145

patchpost-update.sample referenced obsolete binary "git-update-server-info"

Subject: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

## tl;dr

5 messages between Jul 17, 2009 and Jul 21, 2009. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

Peter Simons· Jul 17, 2009, 15:36 UTC · lore

	Modified

Show changes to templates/hooks--post-update.sample +1 −1

diff --git a/templates/hooks--post-update.sample b/templates/hooks--post-update.sample
index 5323b56..ec17ec1 100755
--- a/templates/hooks--post-update.sample
+++ b/templates/hooks--post-update.sample
@@ -5,4 +5,4 @@
 #
 # To enable this hook, rename this file to "post-update".
 
-exec git-update-server-info
+exec git update-server-info

Michael J Gruber· Jul 17, 2009, 16:12 UTC · re: Peter Simons · lore

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

Peter Simons venit, vidit, dixit 17.07.2009 17:36:

Show 13 quoted lines

> 
> 	Modified 
> diff --git a/templates/hooks--post-update.sample b/templates/hooks--post-update.sample
> index 5323b56..ec17ec1 100755
> --- a/templates/hooks--post-update.sample
> +++ b/templates/hooks--post-update.sample
> @@ -5,4 +5,4 @@
>  #
>  # To enable this hook, rename this file to "post-update".
>  
> -exec git-update-server-info
> +exec git update-server-info
>

Have you actually tried? t/t5540-http-push.sh should fail if this really needed a fix (libexec is in $PATH for hooks).

Michael

Peter Simons· Jul 20, 2009, 14:46 UTC · re: Michael J Gruber · lore

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

Hi Michael,

 >> -exec git-update-server-info
 >> +exec git update-server-info
 >>
 >
 > t/t5540-http-push.sh should fail if this really needed a fix (libexec
 > is in $PATH for hooks).

you are right, the call to git-update-server-info does succeed, so there is no need to make that change.

Personally, I find it unfortunate, though, that those scripts rely on commands that won't exist when a normal user runs them.

Just my 2 cents, Peter

Michael J Gruber· Jul 21, 2009, 08:01 UTC · re: Peter Simons · lore

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

Peter Simons venit, vidit, dixit 20.07.2009 16:46:

Show 18 quoted lines

> Hi Michael,
> 
>  >> -exec git-update-server-info
>  >> +exec git update-server-info
>  >>
>  >
>  > t/t5540-http-push.sh should fail if this really needed a fix (libexec
>  > is in $PATH for hooks).
> 
> you are right, the call to git-update-server-info does succeed, so there
> is no need to make that change.
> 
> Personally, I find it unfortunate, though, that those scripts rely on
> commands that won't exist when a normal user runs them.
> 
> Just my 2 cents,
> Peter
>

Anyone can run them, just not from the default $PATH.

In fact, calling the dashed versions from the hooks is both safer and (marginally) more efficient: Many people have several versions of git lying around, and we've had more than one "bug" report where people messed up because of mixing git bits from several versions. Calling the dashed form above relies on the environment as set up by the caller, not the user (who may have several "git" in $PATH, but not "git-update-server-info"). Also, the command is called directly rather than indirectly with "git" having to look for it.

Michael

Peter Simons· Jul 21, 2009, 20:02 UTC · re: Michael J Gruber · lore

Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

Hi Michael,

 > Calling the dashed versions [is safer]: Many people have several
 > versions of git lying around, and we've had more than one "bug"
 > report where people messed up because of mixing git bits from several
 > versions.

right, this is a good point. Thank you for sharing this insight.

Take care, Peter