{"thread":{"id":"20145","subject":"[PATCH] post-update.sample referenced obsolete binary \"git-update-server-info\"","startedAt":"2009-07-17T15:36:34Z","lastAt":"2009-07-21T20:02:20Z","messageCount":5,"participants":["Peter Simons","Michael J Gruber"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"118178","messageId":"874otb724d.fsf@write-only.cryp.to","threadId":"20145","inReplyTo":null,"subject":"[PATCH] post-update.sample referenced obsolete binary \"git-update-server-info\"","fromName":"Peter Simons","fromEmail":"simons@cryp.to","sentAt":"2009-07-17T15:36:34Z","receivedAt":"2009-07-17T15:36:34Z","isPatch":true,"sender":{"key":"simons@cryp.to","avatar":"https://gravatar.com/avatar/56227a0fffc05e2d0584aecce45f0f1fd2b2c0a464a266dff6c2a4aa9191241e?d=mp&s=160"},"body":"\n\tModified \ndiff --git a/templates/hooks--post-update.sample b/templates/hooks--post-update.sample\nindex 5323b56..ec17ec1 100755\n--- a/templates/hooks--post-update.sample\n+++ b/templates/hooks--post-update.sample\n@@ -5,4 +5,4 @@\n #\n # To enable this hook, rename this file to \"post-update\".\n \n-exec git-update-server-info\n+exec git update-server-info\n"},{"id":"118183","messageId":"4A60A2DC.90506@drmicha.warpmail.net","threadId":"20145","inReplyTo":"874otb724d.fsf@write-only.cryp.to","subject":"Re: [PATCH] post-update.sample referenced obsolete binary \"git-update-server-info\"","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-07-17T16:12:12Z","receivedAt":"2009-07-17T16:12:12Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Peter Simons venit, vidit, dixit 17.07.2009 17:36:\n> \n> \tModified \n> diff --git a/templates/hooks--post-update.sample b/templates/hooks--post-update.sample\n> index 5323b56..ec17ec1 100755\n> --- a/templates/hooks--post-update.sample\n> +++ b/templates/hooks--post-update.sample\n> @@ -5,4 +5,4 @@\n>  #\n>  # To enable this hook, rename this file to \"post-update\".\n>  \n> -exec git-update-server-info\n> +exec git update-server-info\n> \n\nHave you actually tried? t/t5540-http-push.sh should fail if this really\nneeded a fix (libexec is in $PATH for hooks).\n\nMichael\n"},{"id":"118317","messageId":"87r5wb5s4o.fsf@write-only.cryp.to","threadId":"20145","inReplyTo":"4A60A2DC.90506@drmicha.warpmail.net","subject":"Re: [PATCH] post-update.sample referenced obsolete binary \"git-update-server-info\"","fromName":"Peter Simons","fromEmail":"simons@cryp.to","sentAt":"2009-07-20T14:46:47Z","receivedAt":"2009-07-20T14:46:47Z","isPatch":true,"sender":{"key":"simons@cryp.to","avatar":"https://gravatar.com/avatar/56227a0fffc05e2d0584aecce45f0f1fd2b2c0a464a266dff6c2a4aa9191241e?d=mp&s=160"},"body":"Hi Michael,\n\n >> -exec git-update-server-info\n >> +exec git update-server-info\n >>\n >\n > t/t5540-http-push.sh should fail if this really needed a fix (libexec\n > is in $PATH for hooks).\n\nyou are right, the call to git-update-server-info does succeed, so there\nis no need to make that change.\n\nPersonally, I find it unfortunate, though, that those scripts rely on\ncommands that won't exist when a normal user runs them.\n\nJust my 2 cents,\nPeter\n"},{"id":"118358","messageId":"4A6575BE.6040308@drmicha.warpmail.net","threadId":"20145","inReplyTo":"87r5wb5s4o.fsf@write-only.cryp.to","subject":"Re: [PATCH] post-update.sample referenced obsolete binary \"git-update-server-info\"","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2009-07-21T08:01:02Z","receivedAt":"2009-07-21T08:01:02Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Peter Simons venit, vidit, dixit 20.07.2009 16:46:\n> Hi Michael,\n> \n>  >> -exec git-update-server-info\n>  >> +exec git update-server-info\n>  >>\n>  >\n>  > t/t5540-http-push.sh should fail if this really needed a fix (libexec\n>  > is in $PATH for hooks).\n> \n> you are right, the call to git-update-server-info does succeed, so there\n> is no need to make that change.\n> \n> Personally, I find it unfortunate, though, that those scripts rely on\n> commands that won't exist when a normal user runs them.\n> \n> Just my 2 cents,\n> Peter\n> \n\nAnyone can run them, just not from the default $PATH.\n\nIn fact, calling the dashed versions from the hooks is both safer and\n(marginally) more efficient: Many people have several versions of git\nlying around, and we've had more than one \"bug\" report where people\nmessed up because of mixing git bits from several versions. Calling the\ndashed form above relies on the environment as set up by the caller, not\nthe user (who may have several \"git\" in $PATH, but not\n\"git-update-server-info\"). Also, the command is called directly rather\nthan indirectly with \"git\" having to look for it.\n\nMichael\n"},{"id":"118399","messageId":"87y6qhby9f.fsf@write-only.cryp.to","threadId":"20145","inReplyTo":"4A6575BE.6040308@drmicha.warpmail.net","subject":"Re: [PATCH] post-update.sample referenced obsolete binary \"git-update-server-info\"","fromName":"Peter Simons","fromEmail":"simons@cryp.to","sentAt":"2009-07-21T20:02:20Z","receivedAt":"2009-07-21T20:02:20Z","isPatch":true,"sender":{"key":"simons@cryp.to","avatar":"https://gravatar.com/avatar/56227a0fffc05e2d0584aecce45f0f1fd2b2c0a464a266dff6c2a4aa9191241e?d=mp&s=160"},"body":"Hi Michael,\n\n > Calling the dashed versions [is safer]: Many people have several\n > versions of git lying around, and we've had more than one \"bug\"\n > report where people messed up because of mixing git bits from several\n > versions.\n\nright, this is a good point. Thank you for sharing this insight.\n\nTake care,\nPeter\n"}]}