Re: [PATCH] post-update.sample referenced obsolete binary "git-update-server-info"

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jul 21, 2009, 08:01 UTC
Message-ID: <4A6575BE.6040308@drmicha.warpmail.net>
In-Reply-To: <87r5wb5s4o.fsf@write-only.cryp.to>

Peter Simons venit, vidit, dixit 20.07.2009 16:46:

Show 18 quoted lines

> Hi Michael,
> 
>  >> -exec git-update-server-info
>  >> +exec git update-server-info
>  >>
>  >
>  > t/t5540-http-push.sh should fail if this really needed a fix (libexec
>  > is in $PATH for hooks).
> 
> you are right, the call to git-update-server-info does succeed, so there
> is no need to make that change.
> 
> Personally, I find it unfortunate, though, that those scripts rely on
> commands that won't exist when a normal user runs them.
> 
> Just my 2 cents,
> Peter
>

Anyone can run them, just not from the default $PATH.

In fact, calling the dashed versions from the hooks is both safer and (marginally) more efficient: Many people have several versions of git lying around, and we've had more than one "bug" report where people messed up because of mixing git bits from several versions. Calling the dashed form above relies on the environment as set up by the caller, not the user (who may have several "git" in $PATH, but not "git-update-server-info"). Also, the command is called directly rather than indirectly with "git" having to look for it.

Michael